Conversation
…ure flag checks. Updated related commands and tests to utilize policy requirements instead of feature service checks for automatic user confirmation. Cleaned up organization form view by simplifying checkbox rendering for automatic user confirmation.
|
New Issues (1)Checkmarx found the following issues in this Pull Request
|
Bitwarden Claude Code ReviewOverall Assessment: APPROVE This PR removes the Code Review Details
Note: The |
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
…omatic user confirmation. Updated logic to streamline policy requirement checks and cleaned up related tests by removing unnecessary feature flag assertions.
…dated multiple test classes to include checks for `AutomaticUserConfirmationPolicyRequirement`, ensuring no auto-confirm restrictions are applied by default. Refactored related assertions in `AcceptOrgUserCommandTests`, `ConfirmOrganizationUserCommandTests`, `RestoreOrganizationUserCommandTests`, and others to streamline compliance validation logic.
…test classes. Added checks for `AutomaticUserConfirmationPolicyRequirement` in `ConfirmOrganizationUserCommandTests`, `RestoreOrganizationUserCommandTests`, and `SelfHostedOrganizationSignUpCommandTests`, ensuring compliance validation logic is streamlined and consistent. Updated assertions to reflect new policy requirements.
…rs' of https://github.com/bitwarden/server into ac/pm-19934-implement-feature-flag-for-auto-confirm-users
…iderServiceTests to enhance test coverage for user confirmation policies.
…ationPolicyRequirement, enhancing test coverage for user acceptance scenarios.
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #7402 +/- ##
==========================================
- Coverage 58.48% 58.45% -0.03%
==========================================
Files 2063 2067 +4
Lines 91187 90997 -190
Branches 8129 8083 -46
==========================================
- Hits 53332 53195 -137
+ Misses 35957 35901 -56
- Partials 1898 1901 +3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
… by removing feature flag references, improving readability and maintainability of the test suite.
|
JaredScar
deleted the
ac/pm-19934-implement-feature-flag-for-auto-confirm-users
branch
3 participants
🎟️ Tracking
https://bitwarden.atlassian.net/browse/PM-26383
📔 Objective
Removes the feature flag logic from client side for autoconfirm flag