[PM 34174]Do not show renewal reminder banners to exempt organizations#7483
[PM 34174]Do not show renewal reminder banners to exempt organizations#7483cyprain-okeke wants to merge 12 commits intomainfrom
Conversation
…r-banners-to-exempt-organizations
|
New Issues (2)Checkmarx found the following issues in this Pull Request
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #7483 +/- ##
=======================================
Coverage 59.83% 59.84%
=======================================
Files 2103 2103
Lines 92788 92794 +6
Branches 8266 8268 +2
=======================================
+ Hits 55523 55529 +6
Misses 35295 35295
Partials 1970 1970 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
…r-banners-to-exempt-organizations
…r-banners-to-exempt-organizations
b329e2a
…r-banners-to-exempt-organizations
…r-banners-to-exempt-organizations
There was a problem hiding this comment.
I understand this has already gone through QA, but I'm curious as to why we didn't just check that column value in the GetOrganizationWarningsQuery? That would have prevented at least 9 file changes and a SQL migration done as part of this PR. Additionally, it would likely prevent the need for the clients PR entirely because the warning would never make it to the organization-warnings.service in the first place.
amorask-bitwarden
left a comment
There was a problem hiding this comment.
Sorry, meant to put a block on this prior. I would like you to look into the simplicity gain we'd get from just seeing if we can drop the warning at the GetOrganizationWarningsQuery level. If that works and it doesn't surfaces the warning and allows us to drop the clients PR entirely, that's the route we should go to avoid adding unnecessary complexity.
Gate InactiveSubscription and ResellerRenewal warnings inside GetOrganizationWarningsQuery on Organization.ExemptFromBillingAutomation instead of plumbing the field through the profile response, view models, EF queries, and SQL views.
…r-banners-to-exempt-organizations
|
amorask-bitwarden
left a comment
There was a problem hiding this comment.
Looks great - thank you for making the change.





🎟️ Tracking
https://bitwarden.atlassian.net/browse/PM-34174
📔 Objective
Suppress billing renewal reminder banners and subscription status callouts for organizations that are exempt from billing
automation.
Reseller-managed organizations marked as exempt (exemptFromBillingAutomation = true) should not see renewal cycle notifications or
warning callouts related to past due, unpaid, pending cancellation, or canceled subscription statuses.
Changes
Organization)
entirely
while preserving status and date display
Screenshots & Testing
Testing
📸 Screenshots