Skip to content

Migrate server specific skills into correct location#7488

Merged
theMickster merged 1 commit intomainfrom
migrate-server-skills
Apr 21, 2026
Merged

Migrate server specific skills into correct location#7488
theMickster merged 1 commit intomainfrom
migrate-server-skills

Conversation

@theMickster
Copy link
Copy Markdown
Contributor

@theMickster theMickster commented Apr 17, 2026

🎟️ Tracking

PM-35296

📔 Objective

Migrate the server specific skills out of the bitwarden-software-engineer.
Each skill was copy + paste migrated.
Each skill has a minor alteration to the description frontmatter to enhance with a stronger Use when sentence.
The writing-server-code skill no longer has a Repository Orientation section because that's incorrect for a skill to contain.

@theMickster theMickster added the ai-review Request a Claude code review label Apr 17, 2026
@theMickster theMickster requested a review from a team as a code owner April 17, 2026 08:47
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 17, 2026

Bitwarden Claude Code Review

Overall Assessment: APPROVE

This PR migrates four server-specific Claude skills (implementing-dapper-queries, implementing-ef-core, writing-database-queries, writing-server-code) from the bitwarden-software-engineer plugin into the server repo's .claude/skills/ directory. The changes are documentation-only Markdown files containing development guidance for AI assistants. No source code, dependencies, or infrastructure files are affected.

No findings were identified.

@sonarqubecloud
Copy link
Copy Markdown

@github-actions
Copy link
Copy Markdown
Contributor

Logo
Checkmarx One – Scan Summary & Detailsfcee3ffe-613f-47c7-b49d-70f5d33e1400

Great job! No new security vulnerabilities introduced in this pull request

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 17, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 58.98%. Comparing base (bb5506e) to head (556ef61).
⚠️ Report is 25 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #7488   +/-   ##
=======================================
  Coverage   58.98%   58.98%           
=======================================
  Files        2076     2076           
  Lines       91441    91441           
  Branches     8130     8130           
=======================================
+ Hits        53937    53938    +1     
+ Misses      35581    35580    -1     
  Partials     1923     1923           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Copy Markdown
Contributor

@SaintPatrck SaintPatrck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Couple of non-blocking questions.

🌱 I know the purpose of this PR is to migrate Skills from our marketplace, but are allowed-tools going to be updated in a follow-up PR?

Comment on lines +110 to +113
## Further Reading

- [Database migrations (EF)](https://contributing.bitwarden.com/contributing/database-migrations/ef)
- [SQL code style](https://contributing.bitwarden.com/contributing/code-style/sql/)
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❓ Should WebFetch be added to allowed-tools so these links can be followed when needed?

Same question for the other Skills that have these links as additional references.

Copy link
Copy Markdown
Contributor Author

@theMickster theMickster Apr 21, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's chat about it. I don't think I want to have it in there just yet, but, instead, have another heading called ## Sources that is used by Claude during skill development/refinement/improvement to validate that the information found in the skill still matches the information in Contributing Docs.

I am working on this locally with my local user-level CLAUDE.md files. I'll let you know when/if that's ready for a primetime promotion.

@theMickster theMickster merged commit 918faf0 into main Apr 21, 2026
81 of 82 checks passed
@theMickster theMickster deleted the migrate-server-skills branch April 21, 2026 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ai-review Request a Claude code review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants