[PM-34116][PM-34117] Drivers License and Passport#7512
Merged
nick-livefront merged 11 commits intoApr 28, 2026
Conversation
Contributor
|
New Issues (2)Checkmarx found the following issues in this Pull Request
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #7512 +/- ##
==========================================
+ Coverage 59.18% 59.25% +0.07%
==========================================
Files 2077 2081 +4
Lines 91888 92036 +148
Branches 8177 8179 +2
==========================================
+ Hits 54380 54534 +154
+ Misses 35572 35563 -9
- Partials 1936 1939 +3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
…6-34117/drivers-license-passport
| IssuingCountry = DriversLicense.IssuingCountry, | ||
| IssuingState = DriversLicense.IssuingState, | ||
| ExpirationDate = DriversLicense.ExpirationDate, | ||
| LicenseClass = DriversLicense.LicenseClass, |
Contributor
There was a problem hiding this comment.
❓ is there a reason DateOfBirth,IssueDate, and IssuingAuthority are omitted here?
Similarly with the passport below Sex, BirthPlace, and NationalIdentificationNumber are missing.
Tests would need to be updated if these are added.
Contributor
Author
There was a problem hiding this comment.
Nope, they slipped through my own code review. Nice catch! These were the fields that were added after the original requirements. c4f8d2b
prograhamming
approved these changes
Apr 27, 2026
|
nick-livefront
deleted the
vault/pm-34116-34117/drivers-license-passport
branch
jaasen-livefront
pushed a commit
that referenced
this pull request
Apr 29, 2026
* update minimum version to handle all new item types rather than individual types * add cipher types for driverslicense and passport * add request and response models for DriversLicense and Passport * add events for DriversLicense and Passport * add seeder * add additional properties from CXP * add additional fields
nick-livefront
added a commit
to bitwarden/sdk-internal
that referenced
this pull request
May 1, 2026
## 🎟️ Tracking [PM-32691](https://bitwarden.atlassian.net/browse/PM-32691) [PM-32694](https://bitwarden.atlassian.net/browse/PM-3269) Server PR: bitwarden/server#7512 ## 📔 Objective Following suit from #949, this PR adds `Driver's License` and `Passport` cipher types to the SDK. @bitwarden/team-vault-dev - This clients pr: bitwarden/clients#20438 will need to fast follow to fix the breaking changes here and unblock any other SDK updates. Implementation of the new cipher types will follow that PR. ## 🚨 Breaking Changes New `Driver's License` and `Passport` types added to CipherType, CipherListViewType, and CipherViewType — clients must handle [PM-32691]: https://bitwarden.atlassian.net/browse/PM-32691?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ [PM-32694]: https://bitwarden.atlassian.net/browse/PM-32694?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎟️ Tracking
PM-34116
PM-34117
📔 Objective
Building off of #7112, this adds
Driver's LicenseandPassporttypes.📸 Screenshots
N/A