Skip to content

[PM-34615] - add SuppressOnboardingInterstitials setting#7516

Open
jaasen-livefront wants to merge 1 commit intomainfrom
PM-34615
Open

[PM-34615] - add SuppressOnboardingInterstitials setting#7516
jaasen-livefront wants to merge 1 commit intomainfrom
PM-34615

Conversation

@jaasen-livefront
Copy link
Copy Markdown
Collaborator

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-34615

📔 Objective

Adds a new SuppressOnboardingInterstitials global setting to the server as part of PM-34615. When enabled, this setting signals to clients that onboarding interstitials (post-login welcome dialogs, extension install prompts, setup extension redirects, and premium upsell modals) should be suppressed — useful for QA environments where these prompts interfere with automated testing flows.

Server changes

  • Added SuppressOnboardingInterstitials boolean property to GlobalSettings and IGlobalSettings
  • Exposed the property via ServerSettingsResponseModel (returned from GET /config in the settings object)
  • Added unit tests verifying the value maps correctly through ConfigResponseModel

@sonarqubecloud
Copy link
Copy Markdown

@github-actions
Copy link
Copy Markdown
Contributor

Logo
Checkmarx One – Scan Summary & Details3dee530d-8a89-48c9-8cf7-2fde05512b11

Great job! No new security vulnerabilities introduced in this pull request

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 20, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 59.10%. Comparing base (55d5f55) to head (9a95a43).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #7516   +/-   ##
=======================================
  Coverage   59.10%   59.10%           
=======================================
  Files        2078     2078           
  Lines       91697    91700    +3     
  Branches     8150     8150           
=======================================
+ Hits        54194    54196    +2     
- Misses      35572    35573    +1     
  Partials     1931     1931           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@shane-melton shane-melton self-requested a review April 21, 2026 17:37
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Thanks for these!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants