Skip to content

[PM-34148] Implement feature flag for fetching new policies and organization details#7529

Merged
JaredScar merged 1 commit intomainfrom
ac/pm-34148-extend-sync-endpoint-to-return-accepted-data
Apr 30, 2026
Merged

[PM-34148] Implement feature flag for fetching new policies and organization details#7529
JaredScar merged 1 commit intomainfrom
ac/pm-34148-extend-sync-endpoint-to-return-accepted-data

Conversation

@JaredScar
Copy link
Copy Markdown
Contributor

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-34148

📔 Objective

Implements policiesNew and organizationsNew in backend for sync endpoint to be used upon in the frontend going forward until old policies field can be retired.

📸 Screenshots

image

…ails in SyncController (#7506)

- Added support for retrieving confirmed accepted policies and organization user details based on the feature flag 'PoliciesInAcceptedState'.
- Updated SyncResponseModel to include new properties for these details.
- Enhanced SyncControllerTests to verify behavior with the feature flag enabled and disabled.
@JaredScar JaredScar requested a review from a team as a code owner April 22, 2026 18:03
@JaredScar JaredScar added the ai-review Request a Claude code review label Apr 22, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 22, 2026

🤖 Bitwarden Claude Code Review

Overall Assessment: APPROVE

Reviewed the feature-flagged addition of PoliciesNew and OrganizationsNew fields to the sync endpoint, which exposes policies and organization details for users in the Confirmed or Accepted status. The new fields are nullable optional properties on SyncResponseModel, the new constructor parameters are defaulted to null (non-breaking), and the new repository calls are gated by FeatureFlagKeys.PoliciesInAcceptedState. XML documentation on the new properties explains the null-when-disabled contract and the client migration path. Unit tests cover both flag-enabled and flag-disabled paths.

Code Review Details

No findings.

@sonarqubecloud
Copy link
Copy Markdown

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 22, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 59.14%. Comparing base (dbd0d52) to head (c6e5d4d).
⚠️ Report is 31 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #7529   +/-   ##
=======================================
  Coverage   59.13%   59.14%           
=======================================
  Files        2077     2077           
  Lines       91848    91860   +12     
  Branches     8175     8178    +3     
=======================================
+ Hits        54315    54327   +12     
  Misses      35601    35601           
  Partials     1932     1932           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Copy Markdown
Collaborator

@jaasen-livefront jaasen-livefront left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@JaredScar JaredScar merged commit cdfb54e into main Apr 30, 2026
46 of 47 checks passed
@JaredScar JaredScar deleted the ac/pm-34148-extend-sync-endpoint-to-return-accepted-data branch April 30, 2026 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ai-review Request a Claude code review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants