Skip to content

[PM-28346] Use SDK for attachment delete operations#7538

Merged
gbubemismith merged 4 commits into
mainfrom
vault/PM-28346
May 4, 2026
Merged

[PM-28346] Use SDK for attachment delete operations#7538
gbubemismith merged 4 commits into
mainfrom
vault/PM-28346

Conversation

@gbubemismith
Copy link
Copy Markdown
Contributor

@gbubemismith gbubemismith commented Apr 23, 2026

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-28346

📔 Objective

Added feature flag constant for attachment sdk operations

📸 Screenshots

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 28, 2026

Logo
Checkmarx One – Scan Summary & Details27886a5c-8d65-42d3-b8ef-622b64298f0b


New Issues (4) Checkmarx found the following issues in this Pull Request
# Severity Issue Source File / Package Checkmarx Insight
1 MEDIUM CSRF src/Api/Vault/Controllers/CiphersController.cs: 1558
detailsMethod at line 1558 of /src/Api/Vault/Controllers/CiphersController.cs gets a parameter from a user request from id. This parameter value flows ...
Attack Vector
2 MEDIUM CSRF src/Api/Auth/Controllers/AccountsController.cs: 291
detailsMethod at line 291 of /src/Api/Auth/Controllers/AccountsController.cs gets a parameter from a user request from model. This parameter value flow...
Attack Vector
3 MEDIUM CSRF src/Api/Auth/Controllers/AccountsController.cs: 452
detailsMethod at line 452 of /src/Api/Auth/Controllers/AccountsController.cs gets a parameter from a user request from model. This parameter value flow...
Attack Vector
4 MEDIUM CSRF src/Api/Vault/Controllers/CiphersController.cs: 1385
detailsMethod at line 1385 of /src/Api/Vault/Controllers/CiphersController.cs gets a parameter from a user request from id. This parameter value flows ...
Attack Vector

Fixed Issues (4) Great job! The following issues were fixed in this Pull Request
Severity Issue Source File / Package
MEDIUM CSRF src/Api/KeyManagement/Controllers/AccountsKeyManagementController.cs: 145
MEDIUM CSRF src/Api/KeyManagement/Controllers/AccountsKeyManagementController.cs: 97
MEDIUM CSRF src/Identity/Controllers/AccountsController.cs: 138
MEDIUM CSRF src/Api/KeyManagement/Controllers/AccountsKeyManagementController.cs: 173

@gbubemismith gbubemismith requested a review from nikwithak April 29, 2026 13:59
@sonarqubecloud
Copy link
Copy Markdown

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 29, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 59.36%. Comparing base (c281161) to head (8b30e39).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7538      +/-   ##
==========================================
- Coverage   63.81%   59.36%   -4.46%     
==========================================
  Files        2087     2087              
  Lines       92262    92262              
  Branches     8200     8200              
==========================================
- Hits        58880    54770    -4110     
- Misses      31356    35553    +4197     
+ Partials     2026     1939      -87     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

pull Bot pushed a commit to nagyist/bitwarden.server that referenced this pull request May 4, 2026
@gbubemismith gbubemismith merged commit 260b72b into main May 4, 2026
45 checks passed
@gbubemismith gbubemismith deleted the vault/PM-28346 branch May 4, 2026 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants