[PM-32211] fix private key before key rotation#7548
Conversation
|
Moving to draft, since i have discovered that the |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #7548 +/- ##
==========================================
+ Coverage 59.50% 64.03% +4.53%
==========================================
Files 2089 2089
Lines 92421 92617 +196
Branches 8214 8223 +9
==========================================
+ Hits 54994 59309 +4315
+ Misses 35484 31280 -4204
- Partials 1943 2028 +85 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Ready to review. Note, Lint and Tests workflows fail due to separate issue. |
mkincaid-bw
left a comment
There was a problem hiding this comment.
A few changes needed.
# Conflicts: # test/Infrastructure.IntegrationTest/AdminConsole/Repositories/OrganizationUserRepository/OrganizationUserRepositoryTests.cs
|
jrmccannon
left a comment
There was a problem hiding this comment.
Interesting way of passing the transaction around. I am working on a different branch of making the transaction usable via DI.
I would appreciate any feedback you might have on it.
#7555



🎟️ Tracking
https://bitwarden.atlassian.net/browse/PM-32211
📔 Objective
A user may have a corrupt private key. It needs to be fixed before they can rotate their keys or upgrade to v2 encryption. For this, we need to invoke the private key regeneration function and handle status changes for emergency access/organizations.
On key regeneration:
Other changes:
DatabaseTransactionActionnow explicitly provides connection and transactions for EF, since it was discovered in integration testing for Sqlite, that in fact the action run in separate connection - to be confirmed it is testing or production issue too. Migration to this new data structure and pattern for other KM operations is outside of scope https://bitwarden.atlassian.net/browse/PM-35901📸 Screenshots