Skip to content

[PM-13328] Move OrganizationCollectionManagementUpdateRequestModel to AC team#7651

Merged
eliykat merged 1 commit into
mainfrom
ac/pm-13328/server-move-collections-api-to-ac-team
May 18, 2026
Merged

[PM-13328] Move OrganizationCollectionManagementUpdateRequestModel to AC team#7651
eliykat merged 1 commit into
mainfrom
ac/pm-13328/server-move-collections-api-to-ac-team

Conversation

@eliykat
Copy link
Copy Markdown
Member

@eliykat eliykat commented May 16, 2026

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-13328

📔 Objective

Last of the codeowners cleanup on this ticket.

Move OrganizationCollectionManagementUpdateRequestModel into Bit.Api.AdminConsole.Models.Request.Organizations so it's covered by the AC team's CODEOWNERS rule. No behavior change.

@eliykat eliykat added the ai-review Request a Claude code review label May 16, 2026
@eliykat eliykat changed the title [PM-13328] refactor: Move OrganizationCollectionManagementUpdateRequestModel to AC team [PM-13328] Move OrganizationCollectionManagementUpdateRequestModel to AC team May 16, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 16, 2026

🤖 Bitwarden Claude Code Review

Overall Assessment: APPROVE

This PR moves OrganizationCollectionManagementUpdateRequestModel from Bit.Api.Models.Request.Organizations to Bit.Api.AdminConsole.Models.Request.Organizations so the file is covered by the Admin Console team's CODEOWNERS rule (**/AdminConsole @bitwarden/team-admin-console-dev). The class body is unchanged; only the namespace and file path are updated. The three call sites (OrganizationsController.cs, OrganizationsControllerTests.cs, OrganizationAbilityCacheTests.cs) have their using directives updated accordingly, and no behavior is affected.

Code Review Details

No findings. Verified:

  • The new namespace matches the 15 existing sibling files in src/Api/AdminConsole/Models/Request/Organizations/.
  • No remaining references to the old namespace for this specific class.
  • Removing using Bit.Api.Models.Request.Organizations; in OrganizationsControllerTests.cs is safe — the file already had using Bit.Api.AdminConsole.Models.Request.Organizations; and no other type from the old namespace is used.
  • The move aligns with the stated CODEOWNERS cleanup objective (PM-13328).

@eliykat eliykat marked this pull request as ready for review May 16, 2026 05:55
@eliykat eliykat requested a review from a team as a code owner May 16, 2026 05:55
@eliykat eliykat requested a review from BTreston May 16, 2026 05:55
@sonarqubecloud
Copy link
Copy Markdown

@codecov
Copy link
Copy Markdown

codecov Bot commented May 16, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 59.87%. Comparing base (c7c0ab2) to head (6ce4f93).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7651      +/-   ##
==========================================
- Coverage   59.87%   59.87%   -0.01%     
==========================================
  Files        2121     2121              
  Lines       93532    93532              
  Branches     8301     8301              
==========================================
- Hits        56001    56000       -1     
- Misses      35551    35552       +1     
  Partials     1980     1980              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@eliykat eliykat merged commit 1c3dc37 into main May 18, 2026
44 checks passed
@eliykat eliykat deleted the ac/pm-13328/server-move-collections-api-to-ac-team branch May 18, 2026 21:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ai-review Request a Claude code review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants