Skip to content
This repository was archived by the owner on Mar 15, 2024. It is now read-only.

Use correct input types for email and tel (ux improvement for mobile)#661

Closed
coliff wants to merge 1 commit into
bitwarden:masterfrom
coliff:patch-1
Closed

Use correct input types for email and tel (ux improvement for mobile)#661
coliff wants to merge 1 commit into
bitwarden:masterfrom
coliff:patch-1

Conversation

@coliff
Copy link
Copy Markdown
Contributor

@coliff coliff commented Sep 22, 2020

No description provided.

@Hinton
Copy link
Copy Markdown
Member

Hinton commented Jan 10, 2022

Hi @coliff,

Apologies for the late response. Unfortunately setting type="email" or "tel" will toggle validation to ensure the input adheres to the requirements. While this is not necessarily a bad thing, but we would need to apply it to all platforms, not only web.

We are going to be working on adding additional item types according to the roadmap https://community.bitwarden.com/t/bitwarden-roadmap/12865 which seems like a good opportunity to go over these potential breaking changes internally and make a decision.

I'm going to close this PR for now and hopefully it will be included with the additional item types which will start dev work first half 2022.

@Hinton Hinton closed this Jan 10, 2022
@coliff coliff deleted the patch-1 branch January 10, 2022 14:04
@coliff
Copy link
Copy Markdown
Contributor Author

coliff commented Jan 10, 2022

heya @Hinton - thanks for the reply!

I think we could use inputmode="email" and inputmode="tel" instead then. I wrote about that for CSS Tricks:
https://css-tricks.com/everything-you-ever-wanted-to-know-about-inputmode/#aa-tel
https://css-tricks.com/everything-you-ever-wanted-to-know-about-inputmode/#aa-email

That wouldn't use validation, but it would be helpful for tablet/mobile users with virtual keyboards.

@Hinton
Copy link
Copy Markdown
Member

Hinton commented Jan 10, 2022

@coliff That's interesting, I wasn't aware of inputmode. I'll circle this internally with our design theme but in the meanwhile feel free to re-open a PR if you want (since I apparently can't re-open this due to the branch being deleted).

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants