This repository was archived by the owner on Mar 15, 2024. It is now read-only.
Merged
Conversation
cscharf
reviewed
Feb 8, 2021
src/app/send/add-edit.component.ts
Outdated
| } | ||
|
|
||
| copyLinkToClipboard(link: string) { | ||
| // Copy function on web depends on the modal being open or note. Since this event occurs during a transition |
Contributor
There was a problem hiding this comment.
small typo on open or note. => open or not.
cscharf
requested review from
addisonbeck,
mpbw2,
thekazian and
vincentsalucci
Contributor
|
FYI @vincentsalucci , @mportune-bw , @addisonbeck on UI/UX changes here. |
cscharf
approved these changes
Feb 8, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some general send feedback from the last product team meeting:
NOTE: we will probably need to propagate these changes down to other clients where appropriate.