Skip to content
This repository was archived by the owner on Mar 15, 2024. It is now read-only.

Utilize direct Get/PUT for Azure and Local storage.#853

Closed
MGibson1 wants to merge 2 commits intomasterfrom
direct-upload-and-download-of-send-files
Closed

Utilize direct Get/PUT for Azure and Local storage.#853
MGibson1 wants to merge 2 commits intomasterfrom
direct-upload-and-download-of-send-files

Conversation

@MGibson1
Copy link
Member

Overview

Depends on bitwarden/jslib#285

Also receives direct download links from Server and uses those for Accessing a Send.

Files Changed

  • package.json/package-lock.json: Enable azure to upload blobs for us
  • access.component.ts: First grab a download url and use that to download the Send's file
  • messages.json: If no url is received, the send or the send's file cannot be found. Display a can't find message

Draft Reason

Depends on bitwarden/jslib#285

Copy link
Contributor

@cscharf cscharf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good once jslib changes are merged in.

@MGibson1 MGibson1 changed the title Utilize direct Get for Azure and Local storage. Utilize direct Get/PUT for Azure and Local storage. Mar 1, 2021
@MGibson1 MGibson1 closed this Mar 29, 2021
@vincentsalucci vincentsalucci deleted the direct-upload-and-download-of-send-files branch April 18, 2022 16:12
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants