v0.4.2: surface 4 missing hair styles in the wardrobe#25
Merged
Conversation
The character creator's hair carousel offered 11 styles (horns / spiky / cat-ears / pigtails / mohawk / antennae / long / bald / flame / mushroom / tentacles), but the wardrobe only listed 7 — the catalog was missing bald, flame, mushroom, and tentacles. The sprite matrices for all 11 were already baked + bundled, so this was purely a catalog omission: pets hatched with one of the four "missing" styles displayed correctly everywhere except in the wardrobe carousel. Add the four missing entries as starters (matching the existing 7) and add CosmeticCatalogTests as a guard so this drift can't recur. 101 tests passing (was 99); lint + guardrails clean.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was broken
The character creator's hair carousel offers 11 styles: horns, spiky, cat-ears, pigtails, mohawk, antennae, long, bald, flame, mushroom, tentacles. But
CosmeticCatalog's hair slot only listed 7, so bald / flame / mushroom / tentacles were selectable at hatch yet absent from the wardrobe carousel. The sprite matrices for all 11 are baked + bundled (you saw your flame-hair pet render correctly elsewhere) — pure catalog omission.What this PR changes
CosmeticCatalog.allas starters (matching the existing 7).CosmeticCatalogTestswith two guard tests:CharacterCreatorSwatches.hairStylesis also inCosmeticCatalog.CFBundleVersion5 → 6.Sweep results — no other mismatches
Quick audit across all 8 cosmetic slots: hat (7=7), shirt (6=6), pants (6=6), belt (2=2), cape (4=4), eyewear (5=5), held (8=8). Only hair was off (7 catalog vs 11 baked). No other UI drift.
Test plan
swift build && swift testclean (101 tests, +2 new guards)swiftformat --lint .clean./scripts/check.shpasses🤖 Generated with Claude Code