Decouple providers behind capability interfaces#154
Merged
Conversation
bjarneo
added a commit
that referenced
this pull request
Mar 30, 2026
Resolve all merge conflicts from the model split (ui/model.go → ui/model/*.go) and provider interface refactoring (#154). Key changes: - Replace Scrobbler interface with PlaybackReporter (supports multi-provider track ownership via CanReportPlayback) - Add AlbumSortSaver and DefaultAlbumSort() to decouple sort persistence - Rename AlbumInfo.SongCount → TrackCount for provider-neutral naming - Add MetaJellyfinID constant and NavidromeConfig.ScrobbleEnabled() helper - Port all PR changes into the split ui/model/ file structure
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Decouple all providers from the UI and player packages behind
capability interfaces, so new providers can be added by implementing
the right interfaces in external// and registering in main.go.
(Searcher, ArtistBrowser, AlbumBrowser, AlbumTrackLoader,
Scrobbler, PlaylistWriter, PlaylistCreator, PlaylistDeleter,
CustomStreamer, FavoriteToggler, CatalogLoader, CatalogSearcher,
SectionedList, Closer)
a registry-based scheme and URL matcher system
via type assertions — zero external/ imports remain in ui/
the UI Model; scrobbling now uses the Scrobbler interface
all go through generic interfaces