Update keymap to respect responsive height#167
Conversation
…with typed filter/search input
zambetti
force-pushed
the
keys-responsive
branch
from
05b345c to
6587c8b
Compare
| } | ||
| return nil | ||
|
|
||
| case "ctrl+x": |
There was a problem hiding this comment.
I should have described that decision in the PR description rather than only in the commit. When updating the keymap view to support responsive height, I realized that 'x' conflicted with the type-to-filter feature. When I encountered this, I realized that type-to-filter is such a nice feature, it would most certainly speed up the file browser if it were also there. I haven't had time to try to add type-to-filter to the file browser yet, hopefully soon. Thank you for being so responsive; cliamp is a great project, I have it running near-constantly lately throughout the day.
| helpKey("Home/End", "Jump ") + helpKey("Type", "Filter ") + helpKey("Esc", "Close") | ||
| } | ||
|
|
||
| func (m Model) keymapVisibleRows() int { |
There was a problem hiding this comment.
this function is similar to the earlier one? duplicated functions
There was a problem hiding this comment.
Eek. Sorry about this. Related to cleanliness, I've created a follow-up PR with some things that I should have caught in this PR related to scrolling behavior and style consistency across views. I will be more careful.
…scroll state, drop j/k/g/G bindings that conflict with search filter
2 participants
Adapted the
ctrl+kkeymap view to support responsive height, and aligned navigation behavior with other views by adding vim-stylej/kandg/G