feat: support media controller on mac#172
Merged
bjarneo merged 6 commits intobjarneo:mainfrom Apr 7, 2026
Merged
Conversation
Closed
Owner
|
I think I like your approach better than mine. I'll spin it up on my mac and give it a go. |
Owner
|
Works well! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an alternative to #171 that takes a slightly broader approach. Instead of adding macOS support via a registry/init() pattern on top of the existing mpris package, this PR consolidates platform media control into a single mediactl package with explicit wiring.
The mpris code is moved rather than wrapped, dead aliases are removed, and a internal/playback domain layer is introduced so seek/position values use time.Duration throughout instead of raw microseconds.
The trade-off is a larger diff, but it eliminates the side-effect import pattern and gives both platforms a clean shared contract.
Side-note: a neat follow-up to this that I am planning is to also get the song/album art showing in the native media controller.
Closes #70