Fix kbd elements alignment in key-row#231
Merged
Merged
Conversation
📝 WalkthroughWalkthroughUpdates keybindings presentation in site/index.html: changed the ChangesKeybindings Display Updates
🎯 3 (Moderate) | ⏱️ ~20 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Tip 💬 Introducing Slack Agent: The best way for teams to turn conversations into code.Slack Agent is built on CodeRabbit's deep understanding of your code, so your team can collaborate across the entire SDLC without losing context.
Built for teams:
One agent for your entire SDLC. Right inside Slack. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@site/index.html`:
- Line 1945: The displayed keybinding is inconsistent: the label uses uppercase
"J" (<kbd>N then J</kbd>) while the example uses lowercase "j" (<kbd>7j</kbd> =
70%); update one to match the other for clarity — either change the label to
"<kbd>N then j</kbd>" to match the example or change the example to
"<kbd>7J</kbd>" so both use uppercase; make the same change where the strings "N
then J" and "7j" appear in the markup (e.g., around the <kbd> elements) to keep
casing consistent.
- Around line 1943-1945: The site copy of keybindings is out of sync with the
canonical docs: update both representations so they match (or pick
docs/keybindings.md as source-of-truth and propagate to site/index.html).
Specifically, change the "N then J" entry to "N then j" and include the "0j to
start" behavior described in docs, change the "Shift+← / Shift+→" description
from "Seek −/+30s (default)" to indicate it's "(configurable)", and make the
playlist manager entry match the docs ordering and wording by using "p then Esc"
(or reorder to match docs) with the description "Close the playlist manager"
instead of "Close (or clear active filter)"; ensure both docs/keybindings.md and
site/index.html reflect the exact same strings for these bindings.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
There was a problem hiding this comment.
♻️ Duplicate comments (1)
site/index.html (1)
1943-1945:⚠️ Potential issue | 🟠 Major | ⚡ Quick winDocumentation sync issue persists.
While line 1945 now correctly uses lowercase
j(matching the example7j = 70%), the documentation sync issues flagged in previous reviews remain unresolved:
- Line 1944: Description says "Seek −/+30s (default)" but per the previous review,
docs/keybindings.mdstates this is "(configurable)", not a fixed default- Line 1945: The
docs/keybindings.mdfile mentions an0jto start feature that is omitted from the site description- Line 1994 (below): Ordering and wording mismatch between site and docs for the playlist manager close action
As per coding guidelines: "User-facing documentation changes must update both
docs/andsite/index.htmlin sync. This applies to any user-visible changes in keybindings, plugin APIs, providers, or config keys."#!/bin/bash # Compare keybinding descriptions between docs and site echo "=== Checking docs/keybindings.md for seek bindings ===" rg -n -A 1 "N then|Shift.*arrow|Shift.*30" docs/keybindings.md echo -e "\n=== Checking for '0j' or 'configurable' mentions ===" rg -n "0j|configurable" docs/keybindings.md🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@site/index.html` around lines 1943 - 1945, The site copy in site/index.html is out of sync with docs/keybindings.md: update the key-row for "Shift+← / Shift+→" (the element containing "Seek −/+30s (default)") to reflect "configurable" instead of "default", add the missing "0j to start" keybinding to the N then j row or as its own key-row (matching the docs' phrasing and example), and reconcile the playlist manager close action wording/order at the block around the playlist manager entries so it exactly matches docs/keybindings.md; target the key-row elements (the <div class="key-row"> entries for Shift+... and N then j) and the playlist manager section so both site/index.html and docs/keybindings.md are identical for user-facing text.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Duplicate comments:
In `@site/index.html`:
- Around line 1943-1945: The site copy in site/index.html is out of sync with
docs/keybindings.md: update the key-row for "Shift+← / Shift+→" (the element
containing "Seek −/+30s (default)") to reflect "configurable" instead of
"default", add the missing "0j to start" keybinding to the N then j row or as
its own key-row (matching the docs' phrasing and example), and reconcile the
playlist manager close action wording/order at the block around the playlist
manager entries so it exactly matches docs/keybindings.md; target the key-row
elements (the <div class="key-row"> entries for Shift+... and N then j) and the
playlist manager section so both site/index.html and docs/keybindings.md are
identical for user-facing text.
Owner
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This is simply a site-side fix that had broken keybinding containers.
Screenshots / video
Before
After
Summary by CodeRabbit
Documentation
Style