Add nightrider visualizer#247
Conversation
add nightrider plugin
📝 WalkthroughWalkthroughA new community plugin ChangesCommunity Plugin Documentation
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@site/index.html`:
- Around line 2293-2298: The plugin card block using <div
class="community-plugin"> (with child elements community-plugin-name,
community-plugin-desc, community-plugin-author) was placed after the closing
</div> of the <div class="wrap"> container and left an unmatched closing tag;
move that entire community-plugin block so it is nested before the closing tag
of the wrap container (inside the <div class="wrap">) and remove the extraneous
closing tag that currently follows it so the HTML is valid and the plugin
appears inside the layout.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository UI
Review profile: ASSERTIVE
Plan: Pro
Run ID: 232322cf-29b9-4f13-94a7-d6f4b44b03c1
📒 Files selected for processing (2)
docs/community-plugins.mdsite/index.html
| <div class="community-plugin"> | ||
| <div class="community-plugin-name"><a href="https://github.com/HANCORE-linux/cliamp-plugin-nightrider">cliamp-plugin-nightrider</a></div> | ||
| <div class="community-plugin-desc">Nightrider visualizer</div> | ||
| <div class="community-plugin-author"><a href="https://github.com/HANCORE-linux">@HANCORE-linux</a></div> | ||
| </div> | ||
| </div> |
There was a problem hiding this comment.
Fix the HTML structure: plugin card is outside its container.
The new plugin card is placed after the closing </div> on line 2292, which closes the <div class="wrap"> container. This leaves the plugin outside the layout container, and line 2298 adds an unmatched closing tag, creating invalid HTML.
🔧 Proposed fix: move the plugin inside the wrap container
Remove lines 2293-2298 and insert the plugin card before line 2292:
<div class="community-plugin">
<div class="community-plugin-name"><a href="https://github.com/AlexZeitler/cliamp-plugin-led-burst">cliamp-plugin-led-burst</a></div>
<div class="community-plugin-desc">Stereo LED matrix visualizer</div>
<div class="community-plugin-author"><a href="https://github.com/AlexZeitler">`@AlexZeitler`</a></div>
</div>
+ <div class="community-plugin">
+ <div class="community-plugin-name"><a href="https://github.com/HANCORE-linux/cliamp-plugin-nightrider">cliamp-plugin-nightrider</a></div>
+ <div class="community-plugin-desc">Nightrider visualizer</div>
+ <div class="community-plugin-author"><a href="https://github.com/HANCORE-linux">`@HANCORE-linux`</a></div>
+ </div>
</div>
</section>Then delete the incorrectly placed lines 2293-2298.
As per coding guidelines: "User-facing documentation changes must update both docs/ and site/index.html in sync."
🧰 Tools
🪛 HTMLHint (1.9.2)
[error] 2298-2298: Tag must be paired, no start tag: [ ]
(tag-pair)
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@site/index.html` around lines 2293 - 2298, The plugin card block using <div
class="community-plugin"> (with child elements community-plugin-name,
community-plugin-desc, community-plugin-author) was placed after the closing
</div> of the <div class="wrap"> container and left an unmatched closing tag;
move that entire community-plugin block so it is nested before the closing tag
of the wrap container (inside the <div class="wrap">) and remove the extraneous
closing tag that currently follows it so the HTML is valid and the plugin
appears inside the layout.
Hey mate,
I’ve developed a new visualizer plugin for cliamp called nightrider
I'd love for this to be included in the plugin ecosystem.
Let me know If you need any adjustments to the code or documentation to meet your standards!
Summary by CodeRabbit