Skip to content

Add nightrider visualizer#247

Merged
bjarneo merged 2 commits into
bjarneo:mainfrom
HANCORE-linux:add-nightrider-visualizer
May 25, 2026
Merged

Add nightrider visualizer#247
bjarneo merged 2 commits into
bjarneo:mainfrom
HANCORE-linux:add-nightrider-visualizer

Conversation

@HANCORE-linux
Copy link
Copy Markdown
Contributor

@HANCORE-linux HANCORE-linux commented May 25, 2026

Hey mate,

I’ve developed a new visualizer plugin for cliamp called nightrider

I'd love for this to be included in the plugin ecosystem.

Let me know If you need any adjustments to the code or documentation to meet your standards!

Summary by CodeRabbit

  • Documentation
    • Added a new community plugin entry to the documentation and website plugins section with plugin details and author information.

Review Change Stack

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 25, 2026

📝 Walkthrough

Walkthrough

A new community plugin cliamp-plugin-nightrider is added to the project's community documentation and website. The plugin entry is inserted into the community plugins markdown table and as an HTML card in the website's Plugins section.

Changes

Community Plugin Documentation

Layer / File(s) Summary
Add nightrider plugin to documentation and website
docs/community-plugins.md, site/index.html
A new table row documenting cliamp-plugin-nightrider with its GitHub link, description, and author is added to the community plugins markdown table. A corresponding HTML card displaying the plugin name, description, and author link is added to the website Plugins section.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related PRs

  • bjarneo/cliamp#244: Both PRs add new community plugin entries to docs/community-plugins.md following the same documentation pattern.
  • bjarneo/cliamp#245: Both PRs update docs/community-plugins.md and related documentation to register new community visualizer plugins.
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main change: adding a new nightrider visualizer plugin entry to documentation and the website.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@site/index.html`:
- Around line 2293-2298: The plugin card block using <div
class="community-plugin"> (with child elements community-plugin-name,
community-plugin-desc, community-plugin-author) was placed after the closing
</div> of the <div class="wrap"> container and left an unmatched closing tag;
move that entire community-plugin block so it is nested before the closing tag
of the wrap container (inside the <div class="wrap">) and remove the extraneous
closing tag that currently follows it so the HTML is valid and the plugin
appears inside the layout.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: 232322cf-29b9-4f13-94a7-d6f4b44b03c1

📥 Commits

Reviewing files that changed from the base of the PR and between 5085112 and 5c632f4.

📒 Files selected for processing (2)
  • docs/community-plugins.md
  • site/index.html

Comment thread site/index.html
Comment on lines +2293 to +2298
<div class="community-plugin">
<div class="community-plugin-name"><a href="https://github.com/HANCORE-linux/cliamp-plugin-nightrider">cliamp-plugin-nightrider</a></div>
<div class="community-plugin-desc">Nightrider visualizer</div>
<div class="community-plugin-author"><a href="https://github.com/HANCORE-linux">@HANCORE-linux</a></div>
</div>
</div>
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🔴 Critical | ⚡ Quick win

Fix the HTML structure: plugin card is outside its container.

The new plugin card is placed after the closing </div> on line 2292, which closes the <div class="wrap"> container. This leaves the plugin outside the layout container, and line 2298 adds an unmatched closing tag, creating invalid HTML.

🔧 Proposed fix: move the plugin inside the wrap container

Remove lines 2293-2298 and insert the plugin card before line 2292:

     <div class="community-plugin">
       <div class="community-plugin-name"><a href="https://github.com/AlexZeitler/cliamp-plugin-led-burst">cliamp-plugin-led-burst</a></div>
       <div class="community-plugin-desc">Stereo LED matrix visualizer</div>
       <div class="community-plugin-author"><a href="https://github.com/AlexZeitler">`@AlexZeitler`</a></div>
     </div>
+    <div class="community-plugin">
+      <div class="community-plugin-name"><a href="https://github.com/HANCORE-linux/cliamp-plugin-nightrider">cliamp-plugin-nightrider</a></div>
+      <div class="community-plugin-desc">Nightrider visualizer</div>
+      <div class="community-plugin-author"><a href="https://github.com/HANCORE-linux">`@HANCORE-linux`</a></div>
+    </div>
   </div>
 </section>

Then delete the incorrectly placed lines 2293-2298.

As per coding guidelines: "User-facing documentation changes must update both docs/ and site/index.html in sync."

🧰 Tools
🪛 HTMLHint (1.9.2)

[error] 2298-2298: Tag must be paired, no start tag: [ ]

(tag-pair)

🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@site/index.html` around lines 2293 - 2298, The plugin card block using <div
class="community-plugin"> (with child elements community-plugin-name,
community-plugin-desc, community-plugin-author) was placed after the closing
</div> of the <div class="wrap"> container and left an unmatched closing tag;
move that entire community-plugin block so it is nested before the closing tag
of the wrap container (inside the <div class="wrap">) and remove the extraneous
closing tag that currently follows it so the HTML is valid and the plugin
appears inside the layout.

@bjarneo bjarneo merged commit 726640f into bjarneo:main May 25, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants