Implement better command aliases to avoid duped help outupt#33
Merged
Conversation
|
🎉 Build Assets are ready!
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces command alias support for the gh-worktree CLI. It adds an AliasConflictError exception, implements an _alias_map property in WorktreeCommands to manage command aliases, and includes a replace_alias function in the CLI module to resolve aliases from system arguments. Feedback highlights a bug in the AliasConflictError string interpolation and suggests optimizing the replace_alias function by caching the alias map and removing an unnecessary .keys() call.
- dynamically replaces alias with full command in sys args - corrects naming issue with built-in python-fire completion - adds tests for changes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary