Fix building with -DLOVE_SYSTEM_LUA
#856
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously the libdirs were not properly set causing the actual lua libs to be unable to be found at link time
Author
|
accidental regression as I based this off the 0.18.0 cmakelists.txt, will fix |
bjornbytes
reviewed
Mar 13, 2025
bjornbytes
reviewed
Mar 13, 2025
|
|
||
| target_link_directories(lovr PRIVATE | ||
| ${LOVR_LUA_LIBDIR} | ||
| ${LOVR_GLFW_LIBDIR} |
Owner
There was a problem hiding this comment.
Maybe also add OpenXR, for completeness. It may be more convenient to maintain a single list of all the library dirs as well, like LOVR_LIBRARY_DIRS.
bjornbytes
reviewed
Mar 13, 2025
| MACOSX_RPATH TRUE | ||
| BUILD_WITH_INSTALL_RPATH TRUE | ||
| INSTALL_RPATH "@executable_path" | ||
| INSTALL_RPATH "@executable_path;@executable_path/../lib" |
Author
There was a problem hiding this comment.
if lovr is installed to /usr/local/bin then libraries will be in /usr/local/lib, etc
Owner
There was a problem hiding this comment.
Installing to a system-wide location like this isn't supported right now
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously the libdirs were not properly set causing the actual lua libs to be unable to be found at link time