Fix progress_bar return type annotation: Collection → Iterator[T]#2
Merged
Conversation
Merged
Co-authored-by: bjorngun <47886783+bjorngun@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] WIP address feedback from package review discussions
Fix Mar 3, 2026
progress_bar return type annotation: Collection → Iterator[T]
|
Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
progress_baris a generator but was annotated-> Collection, which is both semantically wrong and misleading to type checkers and callers.Changes
src/dev_tools/progress_bar.pyTypeVar TCollection[T]— preserves thelen()(Sized) constraintIterator[T]— accurately reflects the generator behaviour🔒 GitHub Advanced Security automatically protects Copilot coding agent pull requests. You can protect all pull requests by enabling Advanced Security for your repositories. Learn more about Advanced Security.