Merged
Conversation
- Add shell:allow-execute, shell:allow-spawn, shell:allow-stdin-write to Tauri capabilities so the desktop app can run shell commands - Add Windows-aware command routing through powershell.exe/pwsh.exe in the shell tool (sandbox, gateway, and full modes) - Add Windows allowlist (dir, type, findstr, powershell, pwsh, cmd, etc.) - Fix shlex.split for Windows backslash paths in gateway mode - Add Windows env vars (SYSTEMROOT, COMSPEC, etc.) to minimal env - Handle .exe/.cmd/.bat suffixes in Tauri sidecar binary lookup https://claude.ai/code/session_01Fego7poo6HPnc8CDP8xXGz
- Shell tool: route Windows commands through pwsh.exe/powershell.exe, add Windows allowlist (dir, powershell, cmd, etc.), fix shlex on Windows - Safety guard: add 'desktop' mode with confirmation callback for non-TTY contexts (WebSocket-based user confirmation instead of stdin) - Gateway: add safety_confirm_request/response WebSocket protocol for desktop app to surface confirmation dialogs to users - Config: add 'desktop' as valid safety_mode option - Tauri: add shell:allow-execute/spawn/stdin-write capabilities - Sidecar: handle .exe/.cmd/.bat suffixes in binary lookup on Windows - Tests: 21 new dedicated shell/safety tests (all passing) - Kraken verdict: 94% confidence, all changes verified https://claude.ai/code/session_01Fego7poo6HPnc8CDP8xXGz
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.