Skip to content

Expand variables correctly#181

Merged
bkeepers merged 1 commit intobkeepers:masterfrom
sorah:expand-vars-correctly
Apr 3, 2015
Merged

Expand variables correctly#181
bkeepers merged 1 commit intobkeepers:masterfrom
sorah:expand-vars-correctly

Conversation

@sorah
Copy link
Copy Markdown
Contributor

@sorah sorah commented Apr 2, 2015

Previously this fails:

Variable.call("${FOO} \\${FOO} ${FOO}", "FOO" => "BAR") #=> "BAR BAR ${FOO}"

@sorah
Copy link
Copy Markdown
Contributor Author

sorah commented Apr 2, 2015

Oops

@sorah sorah force-pushed the expand-vars-correctly branch 2 times, most recently from ae52cf8 to da7fa8c Compare April 2, 2015 02:58
@sorah
Copy link
Copy Markdown
Contributor Author

sorah commented Apr 2, 2015

Now CI passes.

Previously this fails:

    Variable.call("${FOO} \\${FOO} ${FOO}", "FOO" => "BAR")
    #=> "BAR BAR ${FOO}"
@sorah sorah force-pushed the expand-vars-correctly branch from da7fa8c to 42354f9 Compare April 2, 2015 03:55
@bkeepers
Copy link
Copy Markdown
Owner

bkeepers commented Apr 3, 2015

⚡ awesome, thanks!

bkeepers added a commit that referenced this pull request Apr 3, 2015
@bkeepers bkeepers merged commit f2b55cd into bkeepers:master Apr 3, 2015
@sorah sorah deleted the expand-vars-correctly branch September 7, 2015 12:41
sheax0r pushed a commit to sheax0r/dotenv that referenced this pull request Sep 13, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants