fix(security): Codex follow-up (F1 redaction, F2 rule pattern, F3 audit-chain honesty)#31
Merged
Merged
Conversation
- azure.rs: redact_connection_error wraps reqwest::Error via redact_secrets at LlmError construction; raw e.to_string() no longer enters LlmError - redaction.rs: expand bare-hostname Pass-2 boundary set with : ; < > = & ? \ to scrub host:port, ;-terminated, host=...&port=... forms - stop_auto_summary.rs + recall/mod.rs: redact_secrets before snapshot persist and before recall formatting (closes missed snapshot sink) - transcript.rs (2 sinks), embeddings.rs (6 sinks), recall.rs (1 sink): redact_secrets around every rendered LLM error; 11 of 11 identified sinks wrapped; 1940 workspace tests pass
…1-4/B3-2, T3, Bash(*)x NEW) - matching.rs parse_pattern: require closing ')' to end the string; rejects Bash(*)x trailing-junk that previously matched arbitrary cmds - rules.rs file-loaded whitelist: pass through is_overbroad_allow_pattern (was learned-load only in PR #27); WARN+skip overbroad, deny unaffected - 5 regression tests fail-before/pass-after proven; 865 clx-core tests pass
…inting (R-B5-4, T1) - audit_chain claimed SHA-256 hash-chained validator_disabled audits in v0.8.1 but every hook process called build_record(1, ..., GENESIS_HASH) with no persisted head: records were never cryptographically linked across invocations. CLAUDE.md constraint-integrity: don't claim what isn't true. - reclassified to per-event SHA-256 fingerprinting (the property the code actually delivers and which is genuinely useful for external aggregator re-verification); module/struct/fn/WARN field names updated; verify_chain renamed verify_fingerprint_sequence; 4 regression tests prove the per-event integrity property AND the documented non-linkage across processes; CHANGELOG [Unreleased] entries added for F1/F2/F3 + tracked deferrals (F4 serde_yml + F5/F6/F7) listed honestly
blackaxgit
added a commit
that referenced
this pull request
May 20, 2026
Anti-anchoring prompt + AGENTS overlay + 2026 research + adversarial recon. Already used to drive PR #31.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes 3 of 4 HIGH blockers Codex flagged NO-SHIP on v0.8.1.
Closed
Open / deferred (tracked in CHANGELOG)
Gates 1940 workspace tests pass / clippy -D warnings / fmt / cargo deny check / 9 keychain skips intact. Codex audit at specs/2026-05-19-codex-audit-findings.md. Per-stream evidence bundles at specs/2026-05-19-f{1,2}-findings.md.