test: comprehensive test coverage improvement (618→776 tests)#6
Merged
blackaxgit merged 10 commits intomainfrom Mar 14, 2026
Merged
test: comprehensive test coverage improvement (618→776 tests)#6blackaxgit merged 10 commits intomainfrom
blackaxgit merged 10 commits intomainfrom
Conversation
Add 16 new tests covering tool_recall (empty results, seeded data formatting), tool_remember (storage persistence, embedding failure graceful fallback), tool_checkpoint (snapshot creation with/without note), tool_rules (blacklist add, invalid action), tool_stats (seeded audit data, max-days boundary), handle_tools_call (valid dispatch, missing name), and read_bounded_line (normal, EOF, at-limit, over-limit). Total unit tests in clx-mcp: 78 passing, 0 failing, 1 ignored.
Add 146 new tests (618→764) covering: - Phase 1: MCP validation, paths, config, embeddings, storage, file_util, credentials - Phase 2: Ollama wiremock mocking, hook output/context/audit/learning/transcript/embedding, hook handler integration tests (post_tool_use, pre_compact, session_start/end) - Phase 3: CLI assert_cmd tests for all commands, UserPromptSubmit recall path - Phase 4: Dashboard app state/data loading, property tests (config roundtrip, FTS safety), MCP server init, embedding store integration, recall engine paths Dev-dependencies added: wiremock 0.6, rstest 0.26, insta 1 (yaml/json/redactions), proptest 1.5, assert_cmd 2, predicates 3, mockall 0.13
…d (T39) Add coverage job to CI workflow with: - cargo-llvm-cov with --fail-under-lines 80 gate - LCOV report generation and artifact upload - cargo insta snapshot check (no unreviewed .snap.new files)
- T05: Storage path resolution test - T20: tool_recall seeded data + result format tests - T21: remember embedding failure, stats with seeded data + date range - T34: 7 dashboard UI snapshot tests with ratatui TestBackend + insta - is_available() 3rd test case (HTTP error returns false)
Rust 1.94 clippy enforces backticks around identifiers in doc comments. Also inlines format! variable per clippy::uninlined_format_args.
The settings_tab_load_error snapshot contained a hardcoded home path that differed between macOS and Linux CI runners. Adds HOME path redaction with box-border re-padding in redact_volatile().
Dashboard event loop (event.rs), entry point (mod.rs), and complex settings render code are inherently untestable in CI due to terminal I/O dependencies. Current coverage is 72.75%.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
cargo-llvm-covat 80% line coverage thresholdPhase 1 — Foundation (clx-core, clx-mcp)
Phase 2 — Hooks and MCP (clx-hook, clx-mcp)
Phase 3 — CLI and Integration (clx)
Phase 4 — Dashboard and Polish (clx, clx-core)
CI
cargo-llvm-cov --fail-under-lines 80cargo insta test --check)Test plan
cargo test --workspace— 776 pass, 10 ignored, 0 failedcargo clippy --workspace -- -D warnings— 0 warnings🤖 Generated with Claude Code