fix: use commonjs for package type#168
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
✅ Files skipped from review due to trivial changes (1)
📝 WalkthroughWalkthroughAdded explicit CommonJS Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Suggested labels
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
AB#3939429
ng-packagr 21.2.2 sets
type=modulein package.json. This is a breaking change for projects that useng-packagrto build, but ALSO include schematics. Schematics only support CommonJS. Component libraries by themselves can support either CommonJS or ESM.Summary by CodeRabbit