Skip to content

Conversation

@oussama
Copy link

@oussama oussama commented May 21, 2022

Currently when a BinLogStream is acquired it doesn't decrease the counter on the Pool, which causes the pool panic when it is dropped

@galeaspablo
Copy link
Contributor

I researched this issue further. Taking the connection away from the pool when starting the bin log stream does not keep the pool invariants up to date. Furthermore, taking the connection away from the pool goes against the principle of using a pool (there is already a way to start a connection without a pool).

I wrote a method to close the binlog stream, along withtests (both with and without a pool -- in the case of a pool the test also checks that the pool can be disconnected). Please see #201

@blackbeam
Copy link
Owner

Superseded by #201
@oussama, sorry for delay and thanks for contribution.

1 similar comment
@blackbeam

This comment was marked as duplicate.

@blackbeam blackbeam closed this Jun 1, 2022
@blackbeam blackbeam closed this Jun 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants