Skip to content

cancel connection when acquired by BinLogStream #200

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

cancel connection when acquired by BinLogStream #200

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b5c0381
cancel connection when acquired by binlog_stream
oussama May 20, 2022
11b0ef9
Cargo fmt
galeaspablo May 22, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/conn/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1032,7 +1032,7 @@ impl Conn {

pub async fn get_binlog_stream(mut self, request: BinlogRequest<'_>) -> Result<BinlogStream> {
// We'll disconnect this connection from a pool before requesting the binlog.
self.inner.pool = None;
self.inner.pool.take().map(|pool| pool.cancel_connection());
self.request_binlog(request).await?;

Ok(BinlogStream::new(self))
Expand Down
2 changes: 1 addition & 1 deletion src/conn/pool/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -221,7 +221,7 @@ impl Pool {
///
/// Decreases the exist counter since a broken or dropped connection should not count towards
/// the total.
fn cancel_connection(&self) {
pub(super) fn cancel_connection(&self) {
let mut exchange = self.inner.exchange.lock().unwrap();
exchange.exist -= 1;
// we just enabled the creation of a new connection!
Expand Down