Improve mobile view and convert +page.svelte to TypeScript#2
Open
blackdotbug wants to merge 1 commit intomainfrom
Open
Improve mobile view and convert +page.svelte to TypeScript#2blackdotbug wants to merge 1 commit intomainfrom
blackdotbug wants to merge 1 commit intomainfrom
Conversation
…esponsive mobile CSS; Modal typed; add types.d.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:\n- Make mobile layout responsive so timeline and graph are accessible on small screens.\n- Convert to TypeScript and add d3-force-typed and interfaces.\n- Add for loose module declarations.\n- Type script and add null-safety.\n\nFiles changed: , , .\n\nNotes:\n- svelte-check reports 0 errors after the changes.\n- Kept a small helper as to minimise churn; simulation is strongly typed.\n\nIf you'd like, I can remove the remaining by fully typing all d3 imports in a follow-up.\n