Fix scope calculation dropping existing assets when target is edited#143
Merged
TheTechromancer merged 3 commits intodevfrom Mar 26, 2026
Merged
Fix scope calculation dropping existing assets when target is edited#143TheTechromancer merged 3 commits intodevfrom
TheTechromancer merged 3 commits intodevfrom
Conversation
ausmaster
approved these changes
Mar 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When editing a target (e.g. adding a domain), all previously in-scope assets lost their scope — only the newly added domain would remain in scope.
Root cause: In refresh_asset_scope, when _check_scope returned None (meaning "no change — host was already in scope"), the else catch-all treated it as out-of-scope and removed the target from the asset. Changed else to elif scope_result_type == "ASSET_SCOPE_CHANGED" so that None (no change) correctly leaves scope untouched.
Includes a regression test that reproduces the exact bug.