Fix benchmark report: uv.lock conflict, duplicate comments, broken formatting#2932
Merged
Fix benchmark report: uv.lock conflict, duplicate comments, broken formatting#2932
Conversation
…rmatting
- git clean before branch checkout to prevent uv.lock conflicts when
switching between Poetry/UV branches
- refactor comment posting so both success and failure paths search for
existing comments before creating new ones
- fix fallback message using template literal instead of .join('\\n')
which produced literal \n characters instead of newlines
Contributor
📊 Performance Benchmark Report
📈 Detailed Results (All Benchmarks)
🎯 Performance Summary✅ No significant performance changes detected (all changes <10%) 🐍 Python Version 3.11.14 |
TheTechromancer
approved these changes
Feb 27, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## 3.0 #2932 +/- ##
=====================================
- Coverage 92% 92% -0%
=====================================
Files 434 434
Lines 35493 35496 +3
=====================================
- Hits 32400 32390 -10
- Misses 3093 3106 +13 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
git clean -fdbefore branch checkouts so generated lock files (e.g.uv.lockcreated byuv runon a Poetry branch) don't block switching back to branches that track those filesupsertComment()helper so both success and failure paths search for existing comments before posting — previously the fallback always calledcreateComment(), which is how PR Migrate from Poetry to UV #2900 accumulated 6 duplicate comments.join('\\n')with a template literal — in the YAML|block,'\\n'produced literal backslash-n characters instead of newlines, rendering the fallback comment as one long unformatted lineTest plan
bbot/**/*.pyto trigger the benchmark workflow