Skip to content

Fix benchmark report: uv.lock conflict, duplicate comments, broken formatting#2932

Merged
liquidsec merged 2 commits into3.0from
fix-benchmarks-3-0
Feb 27, 2026
Merged

Fix benchmark report: uv.lock conflict, duplicate comments, broken formatting#2932
liquidsec merged 2 commits into3.0from
fix-benchmarks-3-0

Conversation

@liquidsec
Copy link
Collaborator

Summary

  • uv.lock conflict: git clean -fd before branch checkouts so generated lock files (e.g. uv.lock created by uv run on a Poetry branch) don't block switching back to branches that track those files
  • Duplicate comments: Extracted comment find/update logic into shared upsertComment() helper so both success and failure paths search for existing comments before posting — previously the fallback always called createComment(), which is how PR Migrate from Poetry to UV #2900 accumulated 6 duplicate comments
  • Broken formatting: Replaced .join('\\n') with a template literal — in the YAML | block, '\\n' produced literal backslash-n characters instead of newlines, rendering the fallback comment as one long unformatted line

Test plan

  • Open a PR against 3.0 that touches bbot/**/*.py to trigger the benchmark workflow
  • Verify the benchmark report renders correctly with proper markdown formatting
  • Push again to the same PR and verify the existing comment is updated (not a new one created)
  • If the report script fails, verify the fallback message also updates the existing comment and renders with proper newlines

…rmatting

- git clean before branch checkout to prevent uv.lock conflicts when
  switching between Poetry/UV branches
- refactor comment posting so both success and failure paths search for
  existing comments before creating new ones
- fix fallback message using template literal instead of .join('\\n')
  which produced literal \n characters instead of newlines
@github-actions
Copy link
Contributor

📊 Performance Benchmark Report

Comparing 3.0 (baseline) vs fix-benchmarks-3-0 (current)

📈 Detailed Results (All Benchmarks)

📋 Complete results for all benchmarks - includes both significant and insignificant changes

🧪 Test Name 📏 Base 📏 Current 📈 Change 🎯 Status
Bloom Filter Dns Mutation Tracking Performance 4.27ms 4.28ms +0.2%
Bloom Filter Large Scale Dns Brute Force 17.80ms 17.67ms -0.7%
Large Closest Match Lookup 361.90ms 348.70ms -3.6%
Realistic Closest Match Workload 196.64ms 195.10ms -0.8%
Event Validation Full Scan Startup Small Batch 513.50ms 522.12ms +1.7%
Event Validation Full Scan Startup Large Batch 940.61ms 934.03ms -0.7%
Make Event Autodetection Small 31.46ms 31.42ms -0.1%
Make Event Autodetection Large 318.07ms 312.79ms -1.7%
Make Event Explicit Types 14.19ms 13.91ms -1.9%
Excavate Single Thread Small 4.180s 4.116s -1.5%
Excavate Single Thread Large 10.051s 10.180s +1.3%
Excavate Parallel Tasks Small 4.406s 4.280s -2.9%
Excavate Parallel Tasks Large 7.512s 7.396s -1.5%
Is Ip Performance 3.16ms 3.18ms +0.6%
Make Ip Type Performance 11.47ms 11.29ms -1.7%
Mixed Ip Operations 4.48ms 4.49ms +0.3%
Typical Queue Shuffle 61.63µs 61.51µs -0.2%
Priority Queue Shuffle 705.10µs 704.17µs -0.1%

🎯 Performance Summary

No significant performance changes detected (all changes <10%)


🐍 Python Version 3.11.14

@codecov
Copy link

codecov bot commented Feb 27, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92%. Comparing base (eb8d28b) to head (081586d).
⚠️ Report is 7 commits behind head on 3.0.

Additional details and impacted files
@@          Coverage Diff          @@
##             3.0   #2932   +/-   ##
=====================================
- Coverage     92%     92%   -0%     
=====================================
  Files        434     434           
  Lines      35493   35496    +3     
=====================================
- Hits       32400   32390   -10     
- Misses      3093    3106   +13     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@liquidsec liquidsec merged commit 5098cef into 3.0 Feb 27, 2026
15 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants