Skip to content

make leakix api key mandatory#3112

Merged
liquidsec merged 1 commit into
preset-validationfrom
leakix-mandatory-key
May 21, 2026
Merged

make leakix api key mandatory#3112
liquidsec merged 1 commit into
preset-validationfrom
leakix-mandatory-key

Conversation

@liquidsec

Copy link
Copy Markdown
Collaborator

Summary

  • leakix.net now returns HTTP 401 "Incorrect API Key" for all endpoints (including `/api/subdomains/...` and the `/host/1.1.1.1` ping URL) when no key is provided. Verified manually against the live service.
  • Remove the keyless setup override and conditional header logic. The module now uses the standard `subdomain_enum_apikey.setup()` flow, which soft-fails with "No API key set" if no key is configured.
  • Add `auth_required: True` to meta so the module listing correctly shows `Yes` in the API Key Required column.
  • Drop the `TestLeakIX_NoAPIKey` test, since keyless mode is no longer supported by the upstream API.

@liquidsec liquidsec requested a review from ausmaster May 20, 2026 13:24
@github-actions

github-actions Bot commented May 20, 2026

Copy link
Copy Markdown
Contributor

🚀 Performance Benchmark Report

ℹ️ No baseline benchmark data available

Showing current results for leakix-mandatory-key only.

📊 Current Results (leakix-mandatory-key) - Click to expand

Results

Test Name Mean Time Ops/sec Min Max
Bloom Filter Dns Mutation Tracking Performance 4.32ms 231.3 ops/sec 4.26ms 4.39ms
Bloom Filter Large Scale Dns Brute Force 17.78ms 56.2 ops/sec 17.70ms 17.86ms
Large Closest Match Lookup 355.67ms 2.8 ops/sec 344.43ms 366.76ms
Realistic Closest Match Workload 196.57ms 5.1 ops/sec 195.86ms 197.38ms
Event Memory Medium Scan 2.154s 0.5 ops/sec 2.141s 2.171s
Event Memory Large Scan 10.891s 0.1 ops/sec 10.825s 10.938s
Event Validation Full Scan Startup Small Batch 382.23ms 2.6 ops/sec 380.48ms 383.91ms
Event Validation Full Scan Startup Large Batch 554.51ms 1.8 ops/sec 538.44ms 593.16ms
Make Event Autodetection Small 31.49ms 31.8 ops/sec 31.43ms 31.56ms
Make Event Autodetection Large 320.16ms 3.1 ops/sec 318.76ms 321.88ms
Make Event Explicit Types 14.19ms 70.5 ops/sec 14.14ms 14.25ms
Excavate Single Thread Small 3.854s 0.3 ops/sec 3.820s 3.925s
Excavate Single Thread Large 9.489s 0.1 ops/sec 9.400s 9.563s
Excavate Parallel Tasks Small 4.022s 0.2 ops/sec 3.943s 4.068s
Excavate Parallel Tasks Large 6.434s 0.2 ops/sec 6.368s 6.515s
Is Ip Performance 3.24ms 309.1 ops/sec 3.20ms 3.36ms
Make Ip Type Performance 11.77ms 85.0 ops/sec 11.67ms 12.14ms
Mixed Ip Operations 4.59ms 217.7 ops/sec 4.54ms 4.87ms
Memory Use Web Crawl 611ns 1636.7K ops/sec 611ns 611ns
Memory Use Subdomain Enum 661ns 1512.9K ops/sec 661ns 661ns
Memory Use Deep Chain 721ns 1387.0K ops/sec 721ns 721ns
Memory Use Parallel Chains 661ns 1512.9K ops/sec 661ns 661ns
Scan Throughput 100 3.810s 0.3 ops/sec 3.704s 3.904s
Scan Throughput 1000 29.535s 0.0 ops/sec 29.350s 29.877s
Typical Queue Shuffle 64.02µs 15.6K ops/sec 59.64µs 742.53µs
Priority Queue Shuffle 745.97µs 1.3K ops/sec 696.00µs 1.33ms

🐍 Python Version 3.11.15

@codecov

codecov Bot commented May 20, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90%. Comparing base (7bc8c44) to head (7e8705f).
⚠️ Report is 2 commits behind head on preset-validation.

Additional details and impacted files
@@                Coverage Diff                 @@
##           preset-validation   #3112    +/-   ##
==================================================
+ Coverage                 90%     90%    +1%     
==================================================
  Files                    452     451     -1     
  Lines                  39341   39676   +335     
==================================================
+ Hits                   35235   35543   +308     
- Misses                  4106    4133    +27     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ausmaster

Copy link
Copy Markdown
Contributor

We may want to put this change into #3058 instead and put mandatory=True on it.

@liquidsec liquidsec self-assigned this May 20, 2026
@liquidsec liquidsec force-pushed the leakix-mandatory-key branch from 053454a to 7e8705f Compare May 20, 2026 22:43
@liquidsec liquidsec changed the base branch from dev to preset-validation May 20, 2026 22:43
@liquidsec liquidsec merged commit fe27b84 into preset-validation May 21, 2026
20 checks passed
@liquidsec liquidsec mentioned this pull request Jun 9, 2026
@ausmaster ausmaster deleted the leakix-mandatory-key branch June 11, 2026 01:27
@ausmaster ausmaster added this to the BBOT 3.0 - blazed_elijah milestone Jun 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants