Merge stable into dev (resolve conflicts for #3079)#3198
Merged
Conversation
Replaces the full inline CLA workflow with a thin caller that references the reusable workflow in blacklanternsecurity/.github. CLA logic is now maintained in one place across all BLS repos. This also fixes the bug where org members (e.g. liquidsec) were flagged as unsigned when they committed to an external contributor's PR (#3144). Depends on: blacklanternsecurity/.github#1
Cherry-pick: Replace CLA workflow with centralized reusable workflow
Reusable workflows inherit permissions from the caller, so the caller must declare them. Without this the workflow fails with a silent "workflow file issue" error.
Add permissions block to CLA caller workflow
Walk each path component between the trusted output_dir and the target folder, refusing to proceed if any component is a symlink. This prevents a local attacker from redirecting file writes by pre-planting a symlink at the predictable owner/repo path.
- Python 3.9 -> 3.10 minimum, test matrix drops 3.9 adds 3.14 - starlette >=1.0.1 (+ fastapi >=0.133.0 to allow it) - deepdiff, idna, pyjwt, lxml, orjson, ansible-core, tornado, cryptography, filelock, requests, Pygments, urllib3, pymdown-extensions, pytest, pytest-asyncio
Advisory fix 1
Advisory fix 1
Reject symlinks in github_workflows output path before mkdir
- unarchive: detect symlink/hardlink entries in archives - github_workflows: check output_dir itself for symlinks - github_workflows: sanitize artifact_name with Path.name - Fix TestDockerPullRealmValidation: blasthttp_mock -> httpx_mock
…un-26 2.8.5 Release
ausmaster
approved these changes
Jun 17, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## dev #3198 +/- ##
=====================================
+ Coverage 90% 90% +1%
=====================================
Files 453 453
Lines 46024 46024
=====================================
+ Hits 41154 41155 +1
+ Misses 4870 4869 -1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
blacklanternsecurity/CLA/path (matches badsecrets main)TestBadSecrets_JWTIdentifyOnlyclass from stable removed (referenceshttpxandVULNERABILITY, both replaced in dev)Once merged, #3079 should become a clean merge.