Skip to content

Consolidate HTTP timeout settings#3222

Merged
liquidsec merged 1 commit into
devfrom
consolidate-http-timeout-settings
Jun 25, 2026
Merged

Consolidate HTTP timeout settings#3222
liquidsec merged 1 commit into
devfrom
consolidate-http-timeout-settings

Conversation

@liquidsec

Copy link
Copy Markdown
Collaborator

Summary

  • Removed the confusing blasthttp_timeout / blasthttp_retries config keys (both went through blasthttp anyway)
  • Replaced with a clean http_timeout / http_timeout_infrastructure split, mirroring the existing ssl_verify_target / ssl_verify_infrastructure pattern
  • http_timeout (10s) controls target-directed traffic (probes, crawls, etc.)
  • http_timeout_infrastructure (10s) controls non-target traffic (API calls, wordlist downloads, etc.)
  • api_request() now defaults to http_timeout_infrastructure (same as it already defaults ssl_verify to ssl_verify_infrastructure)
  • HTTP timeouts now log as verbose (instead of debug) with retry attempt counts
  • Consolidated http_retries (removed duplicate blasthttp_retries)

@github-actions

Copy link
Copy Markdown
Contributor

🚀 Performance Benchmark Report

⚠️ No current benchmark data available

This might be because:

  • Benchmarks failed to run
  • No benchmark tests found
  • Dependencies missing

@codecov

codecov Bot commented Jun 19, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 85.00000% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 90%. Comparing base (ef65b09) to head (1213913).

Files with missing lines Patch % Lines
bbot/core/helpers/web/web.py 34% 2 Missing ⚠️
bbot/modules/http.py 86% 1 Missing ⚠️
Additional details and impacted files
@@          Coverage Diff          @@
##             dev   #3222   +/-   ##
=====================================
- Coverage     90%     90%   -0%     
=====================================
  Files        453     453           
  Lines      46101   46109    +8     
=====================================
+ Hits       41211   41214    +3     
- Misses      4890    4895    +5     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ausmaster ausmaster assigned ausmaster and liquidsec and unassigned ausmaster Jun 25, 2026
@ausmaster ausmaster self-requested a review June 25, 2026 20:08
@ausmaster ausmaster added this to the BBOT 3.0 - blazed_elijah milestone Jun 25, 2026
@liquidsec liquidsec merged commit 2802c97 into dev Jun 25, 2026
22 of 23 checks passed
@liquidsec liquidsec deleted the consolidate-http-timeout-settings branch June 25, 2026 20:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants