Skip to content

Fix: ADIv5 AP scan early bailout#1135

Merged
esden merged 3 commits intomainfrom
fix/adiv5-ap-early-bailout
Jul 30, 2022
Merged

Fix: ADIv5 AP scan early bailout#1135
esden merged 3 commits intomainfrom
fix/adiv5-ap-early-bailout

Conversation

@dragonmux
Copy link
Member

@dragonmux dragonmux commented Jul 26, 2022

the ADIv5 AP scan bails out too early (on the first encountered invalid AP) rather than after 8 invalid APs.

This was a regression introduced by cda83d3 because that commit checks the wrong loop variable, and then checks the variable against the wrong value. We also fixed the nomenclature up as the code was a litte hard to understand.

This PR fixes this behaviour, fixing #1134.

@dragonmux dragonmux requested a review from esden July 26, 2022 04:34
@dragonmux dragonmux added this to the v1.9 release milestone Jul 26, 2022
@dragonmux dragonmux added Bug Confirmed bug Regression Bug caused by a regression labels Jul 26, 2022
@dragonmux dragonmux linked an issue Jul 26, 2022 that may be closed by this pull request
Copy link
Contributor

@perigoso perigoso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@esden esden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@esden esden merged commit a9fff1e into main Jul 30, 2022
@dragonmux dragonmux deleted the fix/adiv5-ap-early-bailout branch July 30, 2022 23:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Bug Confirmed bug Regression Bug caused by a regression

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ADIv5: APs badly enumerated

3 participants