This repository was archived by the owner on Mar 7, 2026. It is now read-only.
Conversation
…otocol communications with firmware built with ENABLE_DEBUG=1
…ey better adhere to protocol
… recovery if a fault condition is set for the DP
…ly set by adiv5_swdp_scan(), don't set them again
dragonmux
added
Bug
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Detailed description
In this PR we address the SWD regression identified in #1359 which was caused by the protocol recovery addition in https://github.com/blackmagic-debug/blackmagic/pulls/1331 exposing the DPv2+ protocol recovery being incorrect and scan not setting the DP version field so causing recovery to progress incorrectly (post-recovery the device had DP#0 reselected in the multi-drop chain making things work when they shouldn't).
After this change, discovery and recovery both work correctly and reliably for DPv0, DPv1 and DPv2 SWD devices.
Your checklist for this pull request
make PROBE_HOST=native)make PROBE_HOST=hosted)Closing issues
Fixes #1359