Skip to content

dedicated task views (and other task-related improvements) #70

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
GamerGirlandCo wants to merge 17 commits into from
Closed

dedicated task views (and other task-related improvements) #70

GamerGirlandCo wants to merge 17 commits into from

Conversation

@GamerGirlandCo
Copy link
Collaborator

@GamerGirlandCo GamerGirlandCo commented Oct 28, 2024

this pull request adds:

  • a $text field containing the text of task and list items
  • a $strippedText field containing the text of task and list items, sans inline fields
  • Task and TaskList components for displaying one or multiple tasks, respectively

a demo

task demo

i've been working on this branch privately for awhile, but i think it's almost ready for a proper review.

as always, feedback is welcome!!

@GamerGirlandCo GamerGirlandCo changed the base branch from master to feat/controlled-editable October 28, 2024 00:25
@GamerGirlandCo GamerGirlandCo force-pushed the feat/controlled-editable branch from 682e263 to 4bcd875 Compare October 28, 2024 22:01
@GamerGirlandCo GamerGirlandCo force-pushed the feat/controlled-editable branch from 4bcd875 to 9a3705e Compare October 28, 2024 22:09
@GamerGirlandCo GamerGirlandCo force-pushed the feat/tasks branch 2 times, most recently from 84ac85f to 7815ada Compare November 1, 2024 03:39
@GamerGirlandCo GamerGirlandCo force-pushed the feat/controlled-editable branch from e7a08fa to 1ed2b0d Compare November 2, 2024 22:47
@GamerGirlandCo GamerGirlandCo force-pushed the feat/controlled-editable branch from 1ed2b0d to f4047c4 Compare November 3, 2024 02:04
@GamerGirlandCo GamerGirlandCo force-pushed the feat/controlled-editable branch from f4047c4 to 8099c23 Compare November 3, 2024 20:52
@GamerGirlandCo GamerGirlandCo force-pushed the feat/controlled-editable branch from 8099c23 to 8c41278 Compare November 3, 2024 22:21
@GamerGirlandCo GamerGirlandCo force-pushed the feat/controlled-editable branch from 8c41278 to 4938964 Compare November 3, 2024 23:40
@GamerGirlandCo GamerGirlandCo force-pushed the feat/controlled-editable branch from 4938964 to 8959b46 Compare November 3, 2024 23:58
@GamerGirlandCo GamerGirlandCo force-pushed the feat/controlled-editable branch from 8959b46 to 44e15ef Compare November 4, 2024 18:25
@GamerGirlandCo GamerGirlandCo force-pushed the feat/controlled-editable branch from 44e15ef to 14c10f1 Compare November 4, 2024 20:19
@GamerGirlandCo GamerGirlandCo force-pushed the feat/controlled-editable branch from 14c10f1 to ce820aa Compare November 4, 2024 20:29
@GamerGirlandCo GamerGirlandCo force-pushed the feat/controlled-editable branch from ce820aa to 3ca894c Compare November 4, 2024 20:46
@GamerGirlandCo GamerGirlandCo force-pushed the feat/controlled-editable branch from 3ca894c to 9e92ca5 Compare November 6, 2024 00:04
@GamerGirlandCo GamerGirlandCo force-pushed the feat/controlled-editable branch from 9e92ca5 to 18b0524 Compare January 10, 2025 18:38
@GamerGirlandCo GamerGirlandCo force-pushed the feat/controlled-editable branch from 6c4f4c7 to e99c51e Compare January 12, 2025 18:43
@LuxBetancourt
Copy link

LuxBetancourt commented Feb 18, 2025

This would be amazing! It's currently the biggest thing holding me back from using Datacore

@GamerGirlandCo GamerGirlandCo mentioned this pull request Apr 19, 2025
Closed
@GamerGirlandCo GamerGirlandCo force-pushed the feat/controlled-editable branch from e99c51e to acef0a9 Compare April 19, 2025 21:00
GamerGirlandCo and others added 17 commits April 19, 2025 17:02
@GamerGirlandCo
use a proper codemirror editor instead of a plain textarea for better…
0d1761d 
… UX when editing scripts
@GamerGirlandCo
implement autocomplete via addon plugin
bbe1c50
@GamerGirlandCo
add ability to create views for queries that are treated like any oth…
e55c9cb 
…er file view (e.g., they can be dragged into the sidebar)
@blacksmithgu @GamerGirlandCo
Refactor and simplify a bit of logic
f6ed0ec
@GamerGirlandCo
add task + tasklist components, add utilities for manipulating tasks,…
4a379c1 
… create setting for recursive task completion a-la dataview
@GamerGirlandCo
fix task sublist collapsing not working on first click, remove unused…
f433181 
… imports
@GamerGirlandCo
only show all list fields if displayedFields is undefined
375578d
@GamerGirlandCo
remove old editable file
f512ba2
@GamerGirlandCo
fix type errors, remove old duplicate
a31aa4e
@GamerGirlandCo
move lists.css into views folder, remove duplicate fields.css
7a6884c
@GamerGirlandCo
fix task/list items being too wide
6994d7b
@GamerGirlandCo
task responsiveness fixes
aebb0d0
@GamerGirlandCo
change useListItemEditing hook's signature to accept a new task status
6bddfe8
@GamerGirlandCo
fix for multiline list items
28ebd1a
@GamerGirlandCo
make editable elements fill parent's space
d13a67d
@GamerGirlandCo
memoize hasChildren variable
2a9c688
@GamerGirlandCo
fix dispatch not updating the value straight away
45a0c0f
@GamerGirlandCo GamerGirlandCo deleted the branch feat/controlled-editable April 19, 2025 21:38
@GamerGirlandCo GamerGirlandCo deleted the feat/tasks branch April 19, 2025 21:38
@SettingDust
Copy link

SettingDust commented Apr 20, 2025

Why you closed?

@GamerGirlandCo
Copy link
Collaborator Author

GamerGirlandCo commented Apr 20, 2025

Why you closed?

commit history got too long and polluted with removed stuff, so i figured i'd start again

@GamerGirlandCo
Copy link
Collaborator Author

GamerGirlandCo commented Apr 20, 2025

check #100 for further updates.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@GamerGirlandCo @LuxBetancourt @SettingDust @blacksmithgu