Skip to content

Refactoring EquationArray concepts #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 5, 2025
Merged

Refactoring EquationArray concepts #2

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 4 additions & 17 deletions src/day7.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,26 +24,13 @@ template<typename T>
concept IsEquation = std::is_same_v<T, Equation>;

template<typename T>
concept EquationArrayContainer = requires(T a)
concept EquationArray = requires(T a)
{
requires IsEquation<std::iter_value_t<decltype(std::begin(a))>>;
requires std::forward_iterator<decltype(std::begin(a))>;
requires std::forward_iterator<decltype(std::end(a))>;
requires IsEquation<std::iter_value_t<decltype(std::begin(std::declval<T&>()))>>;
requires std::forward_iterator<decltype(std::begin(std::declval<T&>()))>;
requires std::forward_iterator<decltype(std::end(std::declval<T&>()))>;
};

template<typename T>
concept EquationPointerArray = std::is_pointer_v<T> && IsEquation<std::remove_pointer_t<T>>;

template<typename T>
concept EquationBoundedArray = std::is_bounded_array_v<T> && requires(T a)
{
requires IsEquation<std::remove_cvref_t<decltype(a[0])>>;
};

template<typename T>
concept EquationArray = EquationArrayContainer<T> || EquationPointerArray<T> || EquationBoundedArray<T>;


// TODO: replace the function with std::from_chairs, that becomes constexpr in C++23.
[[nodiscard]] constexpr std::pair<int64_t, size_t> parseNumber(std::string_view str) noexcept {
constexpr auto char_to_int = [](char c) {
Expand Down