feat: Reduce ipsw diff memory usage
#986
Open
+547
−382
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
ipsw diffconsumed 48GB+ RAM, crashing on 16GB and lower memory machines.Changes
This PR contains improvements for in-memory diffing and the addition of disk-cached diffing.
1. Streaming DMG Traversal (
internal/search/search.go)[]stringslices2. Per-Image DSC Diff (
internal/commands/dsc/diff.go)map[string]*DiffInfomaps3. Optional Disk Caching (
internal/commands/macho/diff.go)--low-memoryflag for low memory machinesDiffInfoto temp gob files, loads on-demand4. Stream gob.Encode (
internal/diff/diff.go)Save()now streams directly to file instead of buffering inbytes.BufferUsage
Fixes #985