fix: validate overmind socket liveness on start/stop#15
Open
bicabone wants to merge 3 commits into
Open
Conversation
overmind start -D returns 0 even when the child process dies immediately, and overmind quit leaves stale socket files behind. This caused start to falsely report success and stop to fail finding a running server. - Start now polls for socket existence after daemonizing to verify overmind actually stayed alive - Start checks socket liveness via overmind status before reporting "already running", cleaning up stale sockets - Stop validates socket is live before attempting quit - Stop removes socket file after successful quit 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
- `tctx status` shows overmind process status or PID-based status - `tctx logs` tails overmind echo output for the dev server - Both report "not running" cleanly when server is down - Cleans up stale sockets on status/logs checks 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
overmind status exits 0 even when processes are dead. Check for "running" in the output instead. Also wait 1s after start before verifying, and clean up dead overmind sessions on detection. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
tctx startfalsely reporting success when overmind child process dies immediatelytctx stopfailing on stale socket files left behind byovermind quitChanges
overmind statusbefore reporting "already running"; clean up stale socketsovermind statusbefore attempting quit; clean up stale socketsovermind quitstatuscommand to fake overmind stub🤖 Generated with Claude Code