Skip to content

Conversation

@whymarrh
Copy link
Contributor

This PR moves @types/debug into devDependencies as it shouldn't be needed in dependencies

@coveralls
Copy link

Coverage Status

Coverage remained the same at 95.092% when pulling 52f400a on whymarrh:types-dependency into 1fd2515 on blakeembrey:master.

@blakeembrey
Copy link
Owner

I'm ok, I'd like to keep the @types with its dependency. You never know when the type may be accidentally exported because the tooling unfortunately doesn't exist for that kind of checking.

@whymarrh
Copy link
Contributor Author

You never know when the type may be accidentally exported because the tooling unfortunately doesn't exist for that kind of checking.

Could I bother you for a clarification on this? I don't understand the situation you're describing.

@blakeembrey
Copy link
Owner

export const str: string;

The type is now exported. It can happen just as easily if a type (e.g. function signature) were exported from debug. Not saying this would happen, but I'd avoid to have to make every person and myself remember to check this since there's no tooling to verify it isn't happening.

@whymarrh
Copy link
Contributor Author

Ah, yes, you're talking about types you depend on for your own type defns. Thanks for the clarification.

@whymarrh whymarrh deleted the types-dependency branch December 18, 2017 19:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants