Skip to content

Fix LiveKit reasoning effort default for gpt-5.4 models#144

Merged
mstolarzblaxelai merged 1 commit into
mainfrom
mstolarz/eng-2508-livekit-reasoning-effort
May 14, 2026
Merged

Fix LiveKit reasoning effort default for gpt-5.4 models#144
mstolarzblaxelai merged 1 commit into
mainfrom
mstolarz/eng-2508-livekit-reasoning-effort

Conversation

@mstolarzblaxelai
Copy link
Copy Markdown
Contributor

@mstolarzblaxelai mstolarzblaxelai commented May 13, 2026

Fixes ENG-2508.

What changed:

  • Default LiveKit reasoning_effort to none for Blaxel-resolved OpenAI gpt-5.4 models.
  • Preserve caller-provided reasoning_effort exactly.
  • Leave non-OpenAI provider behavior unchanged.

Why:

  • Current LiveKit defaults gpt-5.4-mini to minimal.
  • Blaxel rejects minimal for this model. Supported values include none, low, medium, high, and xhigh.

Verified:

  • uv run --locked --python 3.12 --extra livekit --group test pytest tests/integration/livekit/test_model.py::test_gpt54_openai_models_default_reasoning_effort_to_none tests/integration/livekit/test_model.py::test_livekit_reasoning_effort_override_is_preserved tests/integration/livekit/test_model.py::test_livekit_non_openai_provider_does_not_default_reasoning_effort -q
  • BL_WORKSPACE=main uv run --locked --python 3.12 --extra livekit --group test pytest tests/integration/livekit/test_model.py::TestBlModel::test_can_call_model -q
  • BL_WORKSPACE=main uv run --locked --python 3.12 --extra livekit --group test pytest tests/integration/livekit -q
  • uv run ruff check .
  • make test
  • git diff --check

Note

Adds a helper that defaults reasoning_effort to "none" for gpt-5.4 family models on the OpenAI provider in the LiveKit integration, preventing Blaxel from rejecting the LiveKit-default value of "minimal". Three focused unit tests cover the happy path, caller override, and non-OpenAI provider passthrough.

Written by Mendral for commit dd8df73.

Copy link
Copy Markdown
Contributor

@mendral-app mendral-app Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Fix is correct and well-scoped. No security, correctness, or data-loss issues.

Tag @mendral-app with feedback or questions. View session

@mstolarzblaxelai mstolarzblaxelai marked this pull request as ready for review May 14, 2026 18:12
@mstolarzblaxelai mstolarzblaxelai merged commit c82bf03 into main May 14, 2026
17 checks passed
@mstolarzblaxelai mstolarzblaxelai deleted the mstolarz/eng-2508-livekit-reasoning-effort branch May 14, 2026 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant