Pre-Release Cleanup: Migrate deprecated packages, remove logs, and verify configurations

[coderabbitai]

Pre-Release Cleanup Checklist

This issue tracks cleanup items identified during review of PR #20 before production release.

🔴 Critical - Deprecated Package Migration

• Replace System.Data.SqlClient with Microsoft.Data.SqlClient across all projects
  • System.Data.SqlClient NuGet package is officially deprecated by Microsoft
  • Package is referenced in 7 project files but NOT actually used in any code (no using statements found)
  • Projects affected:
    • aspnet-core/src/Moipone.PublicSite.Web.Host/Moipone.PublicSite.Web.Host.csproj
    • aspnet-core/src/Moipone.PublicSite.Web.Core/Moipone.PublicSite.Web.Core.csproj
    • aspnet-core/src/Moipone.PublicSite.EntityFrameworkCore/Moipone.PublicSite.EntityFrameworkCore.csproj
    • aspnet-core/src/Moipone.PublicSite.Migrator/Moipone.PublicSite.Migrator.csproj
    • aspnet-core/src/Moipone.PublicSite.Application/Moipone.PublicSite.Application.csproj
    • aspnet-core/src/Moipone.PublicSite.Core/Moipone.PublicSite.Core.csproj
    • aspnet-core/test/Moipone.PublicSite.Tests/Moipone.PublicSite.Tests.csproj
  • Note: Since project uses PostgreSQL (Npgsql), verify if System.Data.SqlClient is even needed. If not, simply remove it.
  • Reference: Microsoft Deprecation Announcement

🟡 Medium Priority - Build Artifacts & Logs

• Remove committed log file: aspnet-core/src/Moipone.PublicSite.Web.Host/App_Data/Logs/Logs.txt
  • 268 lines of debug/error logs were committed in PR Implemented MVP CRUDs & Secured Internal Endpoints #20
  • Contains sensitive information: connection strings, stack traces, database errors
• Verify .gitignore patterns for logs and build artifacts
  • Ensure aspnet-core/.gitignore excludes:
    • **/Logs/ or **/App_Data/Logs/
    • **/*.log, **/*.txt in log directories
    • bin/, obj/ folders

🟡 Medium Priority - Unused Dependencies

• Audit System.Text.Encodings.Web 10.0.2 usage
  • Package added to 7 projects but no using System.Text.Encodings.Web found in codebase
  • Verify if this is a transitive dependency requirement or can be removed:
    • Check if required by EF Core 10.0.2 or other dependencies
    • Remove from projects if not needed

🟢 Low Priority - Code Quality Review

• Review EmployeeDto.Address property type change

  • Changed from AddressDto? to Address? in PR Implemented MVP CRUDs & Secured Internal Endpoints #20
  • Verify AutoMapper configuration handles domain entity directly
  • Ensure no serialization issues with entity vs DTO
  • File: aspnet-core/src/Moipone.PublicSite.Application/Employees/Dto/EmployeeDto.cs

• Verify authorization is configured correctly

  • 18 [AbpAuthorize] attributes added across multiple endpoints
  • Ensure permission definitions exist for all secured endpoints
  • Test that authorization policies work as expected

• Database connection error investigation

  • Committed logs show repeated PostgreSQL connection errors:
    • "host" parameter missing from connection strings
    • Timeout errors and constraint violations
  • Verify all connection strings in appsettings are properly configured
  • Test database connectivity in all environments

📝 Additional Notes

• Context: Issues identified during CodeRabbit review of PR Implemented MVP CRUDs & Secured Internal Endpoints #20
• Review Comment: Implemented MVP CRUDs & Secured Internal Endpoints #20 (comment)
• Target: Complete before production release

---

Assignee: @blebelo