Split worker and head node implementations #178
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Node core <=> worker + head node Add handling for a "WorkOrder" message Update head node Topic handling in main instead of in node Start of setting up a common "run" method + minor changes Add description Moving out handlers - install and healtcheck Further trim ported handlers Removing ported config options Remove more ported stuff Offload more common things to the node core Move most of message processing code to the node core Move notifiee code out of "node" package Update node initialization, make node core public/usable outside of worker and head node Add methods for the node API to the new head node impl Fix worker execution Update pBFT execution Worker node - work order tests Add more test cases to work order Update but move the integration tests Move/add integration test for PBFT Move more tests/remove obsolete code Move (uncompleted) last piece of test from the old node codebase Remove file - TBD later Remove obsolete file Head node - simplify roll call/work order request creation Trim down roll call struct - remove "Origin" field
Maelkum
changed the title
dmikey
approved these changes
Dec 26, 2024
Contributor
dmikey
left a comment
dmikey
left a comment
There was a problem hiding this comment.
love the changes to the clarity towards what the nodes are doing!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR splits the head and worker node to separate packages, with the shared functionality existing in a new node core implementation.