Add a Compact() function to gtreap store.#1317
Open
tanzhang0504 wants to merge 1 commit intoblevesearch:masterfrom
Open
Add a Compact() function to gtreap store.#1317tanzhang0504 wants to merge 1 commit intoblevesearch:masterfrom
tanzhang0504 wants to merge 1 commit intoblevesearch:masterfrom
Conversation
Author
|
I did not add batch_size as done by compact() in other two stores, because the in-memory operation is usually much faster, and the caller can adjust the frequency of calling compact() to limit the latency per compact(). PLMK your thoughts. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a fix for memory leak from in-mem index (#374).
I made a fix in the underlying store - #1314. but seems like Compact() function is recommended by the owner - blevesearch/blevex#30.