MB-60971: Avoiding unnecessary persister notifs from merger#2003
Merged
abhinavdangeti merged 3 commits intomasterfrom Mar 26, 2024
Merged
MB-60971: Avoiding unnecessary persister notifs from merger#2003abhinavdangeti merged 3 commits intomasterfrom
abhinavdangeti merged 3 commits intomasterfrom
Conversation
Thejas-bhat
requested review from
CascadingRadium,
Likith101,
abhinavdangeti,
metonymic-smokey and
moshaad7
abhinavdangeti
previously approved these changes
Mar 25, 2024
abhinavdangeti
approved these changes
Mar 26, 2024
abhinavdangeti
changed the title
Member
|
This commit has been reverted with #2005 |
abhinavdangeti
added a commit
that referenced
this pull request
Mar 27, 2024
abhinavdangeti
added a commit
that referenced
this pull request
Apr 4, 2024
…#2006) Authored-by: @Thejas-bhat Original: #2003 - There are chances that the merger doesn't see any eligible segments to be merged in the current iteration which causes the tasks list to be empty. In this situation, merger which didn't update the root snapshot would notify the persister. - Now, if the persister was napping at this point of time, and assuming there were mutations coming into the system (so the root snapshot would be updated by the introducer) would lead to the persister to be awoken and start flushing out the in-memory segments to disk. - Perhaps a better behaviour would be to let the persister nap for the remaining duration such and then let the persister do some work. This would also help in merger waiting for the notification reply (which is like an interrupt fashion type of wait) rather than doing something more expensive of letting merger continue to do work (which the earlier commits of this PR was doing). Some numbers on local testing (~4.18M dataset with lorem ipsum content) With patch ``` "num_bytes_used_ram": 224100280, "num_files_on_disk": 34, "test_bucket:test_bucket._default.travel:num_file_merge_ops": 6, "test_bucket:test_bucket._default.travel:num_file_merge_plan": 0, "test_bucket:test_bucket._default.travel:num_files_on_disk": 34, "test_bucket:test_bucket._default.travel:num_mem_merge_ops": 70, "test_bucket:test_bucket._default.travel:num_persister_nap_merger_break": 4, "test_bucket:test_bucket._default.travel:num_persister_nap_pause_completed": 69, "test_bucket:test_bucket._default.travel:num_root_filesegments": 16, "test_bucket:test_bucket._default.travel:num_root_memorysegments": 0, "TotFileMergePlan": 45, "TotFileMergePlanErr": 0, "TotFileMergePlanNone": 1, "TotFileMergePlanOk": 44, ``` Without patch ``` "num_bytes_used_ram": 252726152, "num_files_on_disk": 45, "test_bucket:test_bucket._default.travel:num_file_merge_ops": 11, "test_bucket:test_bucket._default.travel:num_file_merge_plan": 0, "test_bucket:test_bucket._default.travel:num_files_on_disk": 45, "test_bucket:test_bucket._default.travel:num_mem_merge_ops": 129, "test_bucket:test_bucket._default.travel:num_persister_nap_merger_break": 85, "test_bucket:test_bucket._default.travel:num_persister_nap_pause_completed": 44, "test_bucket:test_bucket._default.travel:num_root_filesegments": 33, "test_bucket:test_bucket._default.travel:num_root_memorysegments": 0, "TotFileMergePlan": 96, "TotFileMergePlanErr": 0, "TotFileMergePlanNone": 1, "TotFileMergePlanOk": 95, ``` --------- Co-authored-by: Thejas-bhat <thejas.orkombu@couchbase.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some numbers on local testing (~4.18M dataset with lorem ipsum content)
With patch
Without patch