Skip to content

MB-61421: Prevent deletion of segments scheduled for copy#2032

Merged
abhinavdangeti merged 9 commits intomasterfrom
mergeRace
May 14, 2024
Merged

MB-61421: Prevent deletion of segments scheduled for copy#2032
abhinavdangeti merged 9 commits intomasterfrom
mergeRace

Conversation

@CascadingRadium
Copy link
Copy Markdown
Member

@CascadingRadium CascadingRadium commented May 13, 2024

  • Use a modified index reader, CopyReader, to mark segments in the Scorch root for online copy/backup operations. This prevents their deletion by the asynchronous cleanup routine during the copy/backup process, thereby mitigating the race condition between the merger/persistor and the copy/backup routine.

Comment thread index.go
Comment thread index/scorch/scorch.go Outdated
@abhinavdangeti abhinavdangeti added this to the v2.4.1 milestone May 13, 2024
@CascadingRadium CascadingRadium changed the title MB-61421,MB-61817: Prevent deletion of segments scheduled for backup MB-61421: Prevent deletion of segments scheduled for backup May 14, 2024
@abhinavdangeti abhinavdangeti changed the title MB-61421: Prevent deletion of segments scheduled for backup MB-61421: Prevent deletion of segments scheduled for copy May 14, 2024
@abhinavdangeti abhinavdangeti merged commit 466f095 into master May 14, 2024
@abhinavdangeti abhinavdangeti deleted the mergeRace branch May 14, 2024 16:36
abhinavdangeti added a commit that referenced this pull request Jun 24, 2024
- Use a modified index reader, CopyReader, to mark segments in the
Scorch root for online copy/backup operations. This prevents their
deletion by the asynchronous cleanup routine during the copy/backup
process, thereby mitigating the race condition between the
merger/persistor and the copy/backup routine.

---------

Co-authored-by: Abhinav Dangeti <abhinav@couchbase.com>
abhinavdangeti added a commit that referenced this pull request Jun 25, 2024
)

- Use a modified index reader, CopyReader, to mark segments in the
Scorch root for online copy/backup operations. This prevents their
deletion by the asynchronous cleanup routine during the copy/backup
process, thereby mitigating the race condition between the
merger/persistor and the copy/backup routine.

Backports: #2032

---------

Co-authored-by: Rahul Rampure <rahul.rampure@couchbase.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants