Skip to content

Conversation

@CascadingRadium
Copy link
Member

  • Adapt to new SegmentEligibleDocuments interface which allows usage of visitor-pattern based iteration of eligible documents for filtered vector search.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR refactors the vector search architecture to adopt a visitor-pattern based iteration model for eligible documents in filtered vector searches. The change adapts the existing code to implement the new SegmentEligibleDocuments interface from the bleve_index_api package.

Key Changes:

  • Replaced direct slice return (SegmentEligibleDocs) with an iterator-based approach (SegmentEligibleDocuments)
  • Introduced eligibleDocumentList and eligibleDocumentIterator types to support the new visitor pattern
  • Updated VectorReader to use the new Count() method instead of directly checking slice length

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

CascadingRadium and others added 3 commits December 28, 2025 19:45
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated no new comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 20851311548

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 85.464%

Totals Coverage Status
Change from base Build 19180002944: 0.0%
Covered Lines: 488
Relevant Lines: 571

💛 - Coveralls

@CascadingRadium CascadingRadium moved this from Done to In Progress in Vector Search v2 Jan 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: In Progress

Development

Successfully merging this pull request may close these issues.

3 participants