add resource command tests for every CLI action#8
Merged
Conversation
Mocks fetch, captures the URL/method/body of each apiGet/apiPost/apiPut/ apiDelete call, and asserts the action functions construct them correctly. Covers all 50+ command actions in src/commands/resources.ts — existing receivers/bank_accounts/payouts/payins/quotes/webhook_endpoints/partner_fees/ api_keys/virtual_accounts/offramp_wallets/instances/available, plus the new wallets/transfers/transfer_quotes/fees/tos/upload groups and the fixed receivers limits paths. Also pins one error-path behavior per shape: non-2xx responses route through handleApiError, validation errors are surfaced from the body.
- CLAUDE.md: document the testing infrastructure (helpers, mock fetch pattern, exit-code convention) and add a 'step 3' in the sync workflow conventions telling the api-sync agent to add/update/remove tests alongside command changes. Also fix the stale 'bump CLI_VERSION in constants.ts' instruction left over from PR #6 — package.json is the source of truth now. - api-sync.yml: mirror the same instruction in the inline prompt so Claude is told to update resources.test.ts before running 'bun run test'. Step renumbered (now 9 total). - resources.test.ts: capture console.log output (instead of silently dropping it) so error tests can assert what was printed. Upgrade the two error tests to assert the specific exit code (2 for API errors, 1 for client-side) and the JSON error payload shape. Tighten the upload test to assert FormData and that 'file'/'bucket' parts are present, not just typeof === 'object'.
alvseven
force-pushed
the
alves/add-resource-tests
branch
from
9921c5e to
db01098
Compare
The action chooses a URL path from the --network option (evm by default, or solana / stellar). Only the evm default was pinned; the other two branches would have silently regressed. Adds one test per branch. Also forces a head update on this PR so the CI workflow re-fires — the `pull_request.branches: [main]` filter didn't match when the PR was originally opened against alves/backfill-cli-resources, and GitHub does not auto-rerun pull_request on base-branch changes.
- (2) drop the unused contentType: null branch in the fetch stub; responses are always JSON now. - (4) tighten the small create bodies from toMatchObject to toEqual so field removals would actually fail the test (createBlockchainWallet, createPayinQuote, createWebhookEndpoint, createApiKey, createVirtualAccount). Also tighten the large bodies (createReceiver, createBankAccount, createPartnerFee) with their full expected shape including defaulted/null fields — this surfaced two real bodies I'd missed (createBankAccount's swift_ifsc_branch_code: null and createBlockchainWallet's name + external_id defaults). - (5) move uploadFile fixtures off hardcoded /tmp; use a makeTempFile() helper that writes into os.tmpdir() and unlinks in afterEach. - (6) normalize test names toward '<function> → <verb> <path>' or '<function> with --flag → <effect>' for the few that were prose.
Matches the convention used in api-client.test.ts and output.test.ts —
plain verb-phrase descriptions without function-arrow notation, no
'should' prefix. Combined with the describe blocks (Receivers, Bank
Accounts, …) the output reads as natural sentences:
Receivers
✓ lists receivers
✓ fetches a receiver by id
✓ creates a receiver, splitting --name into first_name and last_name
✓ updates only the fields explicitly passed via flags
✓ deletes a receiver by id
…
No semantic changes — every test still asserts the same URL/method/body
as before.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.