Conversation
…te demo script Co-authored-by: blindzero <13959569+blindzero@users.noreply.github.com>
|
@copilot pester tests are red. please fix. |
Co-authored-by: blindzero <13959569+blindzero@users.noreply.github.com>
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 1b3ba901fa
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
Pull request overview
This PR restructures the examples directory to separate mock workflows (runnable out-of-the-box) from live workflows (requiring real infrastructure), and adds CI validation for mock workflows to serve as a release gate.
Changes:
- Reorganized examples into three categories: mock/ (5 workflows), live/ (7 workflows), and templates/ (reserved for future use)
- Enhanced demo script with
-Categoryparameter for filtering workflow types (defaults to 'Mock' for deterministic execution) - Added comprehensive CI tests that validate + plan + execute mock workflows, while live workflows are validation-only
Reviewed changes
Copilot reviewed 5 out of 17 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| tests/WorkflowSamples.Tests.ps1 | Replaced single test block with three category-specific blocks (Mock, Live, Templates); added execution tests for mock workflows |
| examples/workflows/templates/.gitkeep | Added placeholder file to ensure Git tracks the empty templates directory |
| examples/workflows/mock/*.psd1 | Five new mock workflow files demonstrating various IdLE features with Mock provider |
| examples/workflows/live/*.psd1 | Seven new live workflow files demonstrating real-world AD/EntraID scenarios |
| examples/README.md | Added category descriptions, prerequisites matrix, and comprehensive workflow documentation |
| examples/Invoke-IdleDemo.ps1 | Added -Category parameter with filtering logic; updated workflow discovery to support subdirectories |
| README.md | Updated quickstart to clarify Mock vs Live workflow distinction |
- Add validation to prevent execution of Live/Templates workflows - Live workflows require real providers (DirectorySync, Cloud) which are not available in the demo script - Users can still list Live workflows with -List -Category Live - Update README to remove misleading instruction about running Live workflows - Provide clear error message when attempting to run non-Mock workflows Co-authored-by: blindzero <13959569+blindzero@users.noreply.github.com>
- Remove validation that blocked Live/Templates workflow execution - Live workflows can now be attempted but will fail naturally if providers are missing - This preserves the distinction: Mock (works out-of-the-box), Live (requires real providers), Templates (starting points) - Engine provides clear error messages about missing provider capabilities - Update README to clarify behavior and how to run Live workflows - Default remains Mock for safe out-of-the-box experience Co-authored-by: blindzero <13959569+blindzero@users.noreply.github.com>
|
@copilot now runing However, all tests are green. Please have a look, check and fix the issue and make sure a tests covers this for future prevention. |
- Update workflow discovery to recursively search subdirectories - Change from specific glob pattern to directory-based recursive search - Add test coverage for import-idle.ps1 to prevent future regressions - New test validates workflow discovery and script execution - All tests pass (251 passed, 1 skipped) Co-authored-by: blindzero <13959569+blindzero@users.noreply.github.com>
... Fixed in commit 3543bf9. The |
Summary
Restructures examples to prevent broken demo experiences and enable CI validation as a release gate for v0.8.0. Separates workflows into Mock (runnable out-of-the-box), Live (executable with real providers), and Templates (starting points). Fixes
import-idle.ps1helper script to work with the new directory structure.Motivation
Demo script enumerated all workflows including those requiring AD/Entra infrastructure. Default execution selected alphabetically-first workflow (often non-runnable), breaking out-of-the-box experience. No CI validation allowed example drift after breaking changes. Additionally, the
import-idle.ps1helper script was broken after directory restructuring.Type of Change
Changes
Directory structure:
examples/workflows/mock/- 5 workflows runnable withIdLE.Provider.Mock(CI smoke tested)examples/workflows/live/- 7 workflows requiring real providers (executable but requires infrastructure)examples/workflows/templates/- reserved for future use (includes.gitkeepto ensure Git tracking)Demo script (
Invoke-IdleDemo.ps1):-Category Mock|Live|Templates|Allparameter (default:Mock)Get-DemoWorkflows()to filter by categoryCI validation (
WorkflowSamples.Tests.ps1):Developer tools (
tools/import-idle.ps1):*.psd1) to directory-based recursive searchTest coverage:
ImportIdLE.Tests.ps1to validate import-idle script functionalityDocumentation:
examples/README.md: category descriptions, prerequisites, workflow matrixREADME.md: clarified Mock vs Live distinction in QuickstartCategory semantics:
Usage:
Testing
How to test & review
Test Results:
Checklist
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.